Skip to content

[OpenVINO backend] support tri, triu, and tril #21408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2025

Conversation

Mohamed-Ashraf273
Copy link
Contributor

@Mohamed-Ashraf273 Mohamed-Ashraf273 commented Jun 21, 2025

Hi @rkazants
I've supported tri, triu and tril, and they are ready for review.

@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2025

Codecov Report

Attention: Patch coverage is 92.98246% with 4 lines in your changes missing coverage. Please review.

Project coverage is 82.82%. Comparing base (d55a767) to head (4b66e60).

Files with missing lines Patch % Lines
keras/src/backend/openvino/numpy.py 92.98% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21408      +/-   ##
==========================================
+ Coverage   82.81%   82.82%   +0.01%     
==========================================
  Files         565      565              
  Lines       55520    55577      +57     
  Branches     8664     8673       +9     
==========================================
+ Hits        45977    46030      +53     
- Misses       7428     7430       +2     
- Partials     2115     2117       +2     
Flag Coverage Δ
keras 82.63% <92.98%> (+0.01%) ⬆️
keras-jax 63.32% <0.00%> (-0.07%) ⬇️
keras-numpy 58.52% <0.00%> (-0.07%) ⬇️
keras-openvino 34.07% <92.98%> (+0.08%) ⬆️
keras-tensorflow 63.77% <0.00%> (-0.07%) ⬇️
keras-torch 63.43% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Mohamed-Ashraf273 Mohamed-Ashraf273 force-pushed the support_triu branch 2 times, most recently from f178511 to 3bbbf99 Compare June 21, 2025 20:44
@Mohamed-Ashraf273
Copy link
Contributor Author

@rkazants
they are ready.

@Mohamed-Ashraf273 Mohamed-Ashraf273 changed the title [OpenVINO backend] support triu [OpenVINO backend] support tri, triu, and tril Jun 22, 2025
Copy link
Contributor

@rkazants rkazants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fchollet, looks good to me. Recommend to merge.

@Mohamed-Ashraf273
Copy link
Contributor Author

@fchollet

@fchollet
Copy link
Collaborator

Thank you!

@fchollet fchollet merged commit 2615b5b into keras-team:master Jul 24, 2025
7 checks passed
@Mohamed-Ashraf273 Mohamed-Ashraf273 deleted the support_triu branch July 24, 2025 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants