Add coverage on legacy code, remove coverage on applications. #21576
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @hertschuh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request integrates legacy code into the project's code coverage process. By modifying the pyproject.toml configuration, files located in keras/src/legacy will now be included in both coverage reports and during coverage runs, ensuring that these components are properly tested and their coverage tracked alongside the rest of the codebase.
Highlights
- Code Coverage Configuration: The pull request updates the pyproject.toml file to include legacy code in coverage reports.
- Legacy Code Inclusion: Specifically, files within keras/src/legacy are no longer omitted from code coverage calculations.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request enables code coverage for legacy code by removing the keras/src/legacy/* path from the omit lists in pyproject.toml. The change is correct and achieves its goal. I've added one suggestion to improve the maintainability of the configuration file by removing a redundant omit section, which will make future changes easier.
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #21576 +/- ##
===========================================
- Coverage 82.73% 66.80% -15.94%
===========================================
Files 567 562 -5
Lines 56678 57479 +801
Branches 8839 9097 +258
===========================================
- Hits 46895 38397 -8498
- Misses 7609 17073 +9464
+ Partials 2174 2009 -165
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Code on the `legacy` folder is covered as part of normal unit tests and the coverage information is useful. - Tests in the `applications` folder are not run for coverage, so the coverage information is not usefule and is incorrectly pulling the coverage numbers down.
hertschuh
force-pushed
the
legacy_coverage
branch
from
9be42b4 to
5979999
Compare
hertschuh
changed the title
legacyfolder is covered as part of normal unit tests and the coverage information is useful.applicationsfolder are not run for coverage, so the coverage information is not useful and is incorrectly pulling the coverage numbers down.