Skip to content

refactor!: emit esm only package #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor!: emit esm only package #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion demo/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"categories": [
"Other"
],
"main": "./dist/extension.cjs",
"main": "./dist/extension.js",
"engines": {
"vscode": "^1.101.0"
},
Expand Down
2 changes: 1 addition & 1 deletion demo/src/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { useDemoWebviewView } from './webviewView'

const logger = useLogger('Reactive VSCode')

export = defineExtension(() => {
export const { activate, deactivate } = defineExtension(() => {
logger.info('Extension Activated')
logger.show()

Expand Down
2 changes: 1 addition & 1 deletion demo/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"extends": "../tsconfig.base.json",
"compilerOptions": {
"module": "Preserve",
"module": "ESNext",
"strict": true
},
"exclude": [
Expand Down
4 changes: 2 additions & 2 deletions demo/tsdown.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ import { defineConfig } from 'tsdown'

export default defineConfig({
entry: ['src/extension.ts'],
format: ['cjs'],
target: 'node18',
format: ['esm'],
target: 'node20',
minify: true,
external: [
'vscode',
Expand Down
5 changes: 2 additions & 3 deletions packages/core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,10 @@
"exports": {
".": {
"types": "./dist/index.d.ts",
"import": "./dist/index.js",
"require": "./dist/index.cjs"
"import": "./dist/index.js"
}
},
"main": "./dist/index.cjs",
"main": "./dist/index.js",
"types": "./dist/index.d.ts"
}
}
2 changes: 1 addition & 1 deletion packages/core/vite.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ export default defineConfig({
build: {
lib: {
entry: 'src/index.ts',
formats: ['es', 'cjs'],
formats: ['es'],
fileName: 'index',
},
rollupOptions: {
Expand Down
4 changes: 2 additions & 2 deletions packages/creator/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,11 @@
"creator"
],
"bin": {
"create-reactive-vscode": "./dist/index.cjs"
"create-reactive-vscode": "./dist/index.js"
},
"files": [
"README.md",
"dist/index.cjs",
"dist/index.js",
"template"
],
"scripts": {
Expand Down
4 changes: 2 additions & 2 deletions packages/creator/templates/package.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ export default (publisher: string, identifier: string, displayName: string, core
"categories": [
"Other"
],
"main": "./dist/extension.cjs",
"main": "./dist/extension.js",
"engines": {
"vscode": "^1.89.0"
"vscode": "^1.100.0"
},
"activationEvents": [
"onStartupFinished"
Expand Down
2 changes: 1 addition & 1 deletion packages/creator/templates/src.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { window } from 'vscode'
import { message } from './configs'
import { logger } from './utils'

export = defineExtension(() => {
export const { activate, deactivate } = defineExtension(() => {
logger.info('Extension Activated')

useCommand('${identifier}.helloWorld', () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/creator/templates/tsconfig.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ export default `{
"compilerOptions": {
"target": "ES2022",
"lib": ["ES2022"],
"module": "Preserve",
"module": "ESNext",
"moduleResolution": "Bundler",
"resolveJsonModule": true,
"strict": true,
Expand Down
4 changes: 2 additions & 2 deletions packages/creator/templates/tsdownConfig.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ export default `import { defineConfig } from 'tsdown'

export default defineConfig({
entry: ['src/extension.ts'],
format: ['cjs'],
target: 'node18',
format: ['esm'],
target: 'node20',
minify: true,
external: [
'vscode',
Expand Down
2 changes: 1 addition & 1 deletion packages/creator/tsdown.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { defineConfig } from 'tsdown'
export default defineConfig({
entry: ['./index.ts'],
outDir: './dist',
format: ['cjs'],
format: ['esm'],
target: 'node18',
clean: true,
minify: true,
Expand Down
5 changes: 2 additions & 3 deletions packages/reactivity/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,10 @@
"exports": {
".": {
"types": "./dist/index.d.ts",
"import": "./dist/index.js",
"require": "./dist/index.cjs"
"import": "./dist/index.js"
}
},
"main": "./dist/index.cjs",
"main": "./dist/index.js",
"types": "./dist/index.d.ts"
}
}
2 changes: 1 addition & 1 deletion packages/reactivity/vite.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export default defineConfig({
build: {
lib: {
entry: 'src/index.ts',
formats: ['es', 'cjs'],
formats: ['es'],
fileName: 'index',
},
minify: false,
Expand Down
5 changes: 2 additions & 3 deletions packages/vueuse/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,11 +50,10 @@
"exports": {
".": {
"types": "./dist/index.d.ts",
"import": "./dist/index.js",
"require": "./dist/index.cjs"
"import": "./dist/index.js"
}
},
"main": "./dist/index.cjs",
"main": "./dist/index.js",
"types": "./dist/index.d.ts"
}
}
2 changes: 1 addition & 1 deletion packages/vueuse/vite.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ export default defineConfig({
build: {
lib: {
entry: 'src/index.ts',
formats: ['es', 'cjs'],
formats: ['es'],
fileName: 'index',
},
rollupOptions: {
Expand Down