Fix: correct CI on forked repositories #1396
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, our CI runs integration tests that require connection to the database and consequently require credentials for it. However, we don't have control over forks of the repository, so any PR coming from forks won't have access to the credentials, and will fail the CI. Not only that, but we also currently require an approval for the CI to run on PRs coming from forks at any time.
This PR proposes to:
This is made so that we won't require secrets for linting, formatting and unit tests
Having the CI run right when a person makes a PR allows them to see lint/formatting problems right away, while the jobs that use secrets can still require approval
deploy-staging
job into a specific environment as well, following the environment-based secretsRequired changes:
Changes
Closes #1181