feat: Isolate environment configuration from code #1399
Conversation
.env.backend.example
Outdated
| DASH_DB_PASSWORD=${DASH_DB_PASSWORD:-admin} | ||
| DASH_DB_HOST=dashboard_db | ||
| DASH_DB_PORT=${DASH_DB_PORT:-5432} | ||
| USE_DASHBOARD_DB=${USE_DASHBOARD_DB:-False} No newline at end of file |
There was a problem hiding this comment.
nit: leave an empty line at the end of file
There was a problem hiding this comment.
Updated/amended, please check
There was a problem hiding this comment.
The real environment variables for the database are POSTGRES_USER, POSTGRES_PASSWORD and POSTGRES_DB, even though there were being overriden by those other names. You can use the same syntax as it was being used before (like POSTGRES_USER=${DASH_DB_USER:-admin})
There was a problem hiding this comment.
Updated/amended, please check
nuclearcat
force-pushed
the
move-env-files
branch
2 times, most recently
from
4bdbf5b to
7844123
Compare
Updated/amended, please check |
Move environment variable definitions from docker-compose.yml to dedicated .env files. This change aligns with the 12factor.net recommendation of storing configuration in the environment. - Introduces .env.backend.example, .env.db.example, and .env.proxy.example to serve as templates. - Modifies docker-compose.yml to use `env_file` for each service. - Ensures that .env files are ignored by git. Signed-off-by: Denys Fedoryshchenko <[email protected]>
nuclearcat
force-pushed
the
move-env-files
branch
from
7844123 to
2411904
Compare
|
Oh... I was about to approve this PR and add a not that we need to be careful with this because we need to make sure that staging/production have those .env files, and I just saw that the Github CI already broke. The docker services for the integration tests are not being able to run because it won't find any of the .env.something files, could you check that for us? |
|
On staging/deployment i will deal with that, i will check workflows now. |
Signed-off-by: Denys Fedoryshchenko <[email protected]>
|
I think that part is fine now, is other errors relevant? |
The solution was easier than I though 😅 |
Move environment variable definitions from docker-compose.yml to dedicated .env files. This change aligns with the 12factor.net recommendation of storing configuration in the environment.
env_filefor each service.