Skip to content

runtime: lava: Rename TestJob root Node to avoid collisions #2824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

runtime: lava: Rename TestJob root Node to avoid collisions #2824

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion kernelci/runtime/lava.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@
hierarchy.append(item)
return hierarchy

def _get_job_node_result(self, suite_nodes, job_result):

Check warning on line 215 in kernelci/runtime/lava.py

View workflow job for this annotation

GitHub Actions / Lint 

Method could be a function
""" Calculate job node result
If all child test suites pass, the job will be marked as `pass`
If one of the test suites fails, the job will be marked as `fail`
Expand Down Expand Up @@ -259,7 +259,7 @@

return {
'node': {
'name': job_node['name'],
'name': f"{job_node['name']}-lava-testjob",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-main or -group maybe instead of -lava-testjob? I assume this is the group that may contain multiple jobs insides. So I guess we will have a -group and a entries in KCIDB?

Would this change affect eg kselftest where we don' t have such a duplication issue?

'result': job_result,
'artifacts': {},
'data': job_node['data'],
Expand Down