Skip to content

Added optimized git clone script in config/rootfs/debos/scripts/git-operations.sh #2914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

khanheric2003
Copy link

This PR implements standardized git clone optimization for KernelCI rootfs builder scripts to reduce network traffic and improve CI build performance, addressing issue #2894.

Changes Made

  • Added git-operations.sh
  • Created comprehensive documentation
  • Added testing scripts

Technical Details

  • Implements git clone --depth=1 --single-branch pattern
  • Provides git_clone_optimized() function for consistent usage
  • Includes error handling and branch auto-detection

@khanheric2003 khanheric2003 force-pushed the optimzation/git-clone branch from ddc25eb to 31f0d2c Compare June 24, 2025 19:09
@nuclearcat
Copy link
Member

1)No existing script is refactored to call git_clone_optimized()
2)Depth hard-coded to 1 and advertised as optimisation, might break tools that need tags/history (git describe, kernel versioning, patch rebasing).
3)Repos with submodules will fail to clone / build properly
4)No SPDX header, no executable bit set, no shellcheck annotations
5)# Wrapper for backward compatibilitygit_clone() { - we dont have even such function anywhere.

The patch appears machine-generated, adds non-trivial maintenance surface, and yields no actual optimisation.
Sorry, but closing PR.

@nuclearcat nuclearcat closed this Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants