config: runtime: base: lava: improve timeout calculation #2917
+12
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the full job timeout is set to 30 minutes by default, or `job_timeout + 15` if `job_timeout` is defined and exceeds 30 minutes. Those 15 minutes are meant to account for artifacts download and device boot time, but if the test is supposed to last 30 minutes (or almost), then the job might time out before the test is complete. Fix this by making *15* the minimum value for `job_timeout` (and keep falling back to the default 30 minutes otherwise). Also add an additional 10 minutes to account for coverage data post-processing and upload (which usually takes 5-6 minutes) when coverage support is enabled. Signed-off-by: Arnaud Ferraris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the full job timeout is set to 30 minutes by default, or
job_timeout + 15ifjob_timeoutis defined and exceeds 30 minutes. Those 15 minutes are meant to account for artifacts download and device boot time, but if the test is supposed to last 30 minutes (or almost), then the job might time out before the test is complete. Fix this by making 15 the minimum value forjob_timeout(and keep falling back to the default 30 minutes otherwise).Also add an additional 10 minutes to account for coverage data post-processing and upload (which usually takes 5-6 minutes) when coverage support is enabled.