Skip to content

Conversation

@KomanRudden
Copy link

@KomanRudden KomanRudden commented Nov 24, 2025

The Kinde Management API returns HTTP 200 OK for successful create operations (users and organizations), but the SDK's RESPONSE_TYPES mapping only includes 201 status codes. This causes the SDK to return None instead of deserializing the response data. 200 status codes were added for RESPONSE_TYPES.

Checklist

🛟 If you need help, consider asking for advice over in the Kinde community.

@KomanRudden KomanRudden requested a review from a team as a code owner November 24, 2025 12:02
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 24, 2025

Walkthrough

Updated response type mappings in ManagementClient to recognize HTTP 200 status codes for create endpoints alongside existing 201 mappings across multiple resources including users, organizations, roles, permissions, and related entities.

Changes

Cohort / File(s) Summary
Response type mappings for create endpoints
kinde_sdk/management/management_client.py
Expanded RESPONSE_TYPES mappings for create operations across all resources to include HTTP 200 status code recognition in addition to 201, affecting users, organizations, organization_users, organization_user_roles, organization_user_permissions, roles, permissions, feature_flags, api_applications, connected_apps, properties, webhooks, and connections.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Single-file change with homogeneous, repetitive pattern applied across multiple resource mappings
  • Pure data structure updates to response type declarations with no logic or method signature changes
  • Straightforward verification: confirm each mapping correctly pairs HTTP 200/201 with corresponding response types

Possibly related issues

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding HTTP 200 response code support to create operations in the management client.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The pull request description clearly explains the problem (API returns 200 OK but SDK only mapped 201) and the solution (adding 200 status codes to RESPONSE_TYPES), which directly aligns with the changeset modifications.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bigfix/create-operation-200-response

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@KeeganBeuthin
Copy link
Contributor

Awesome @KomanRudden, great stuff here.

The only thing I could suggest would be updating testing coverage along with this, however that can all be handled and updated later on in a bigger overhaul :)

Approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants