Skip to content

Pr 140 #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BrandtKruger wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Pr 140 #145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
37722ba
chore(deps): update dependency pytest-cov to v7
renovate[bot] Nov 25, 2025
381041c
fix: update requirements.txt to match pyproject.toml and add coverage…
BrandtKruger Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,8 @@ zip-safe = false

[tool.poetry.dev-dependencies]
pytest = "^7.4.0"
pytest-cov = "^4.1.0"
pytest-cov = "^7.0.0"
coverage = ">=7.10.6"
pytest-django = "^4.5.2"
mypy = "^1.5.0"
bandit = "^1.7"
Expand Down
3 changes: 2 additions & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@ pydantic>=2.0.0,<3.0.0
pytest>=7.4.0
pytest-django>=4.5.2
pytest-asyncio>=0.21.1
pytest-cov>=4.1.0
pytest-cov>=7.0.0
coverage>=7.10.6
Comment on lines +26 to +27
Copy link
Contributor

@coderabbitai coderabbitai bot Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Check if pyproject.toml exists and compare dependencies
if [ -f pyproject.toml ]; then
  echo "=== Checking pyproject.toml for pytest-cov and coverage dependencies ==="
  grep -E "(pytest-cov|coverage)" pyproject.toml
else
  echo "pyproject.toml not found"
fi

# Check requirements.txt context
echo ""
echo "=== Full requirements.txt content ==="
cat requirements.txt

# Search for any version constraints or dependency definitions
echo ""
echo "=== Searching for related documentation or comments about pytest-cov ==="
rg -i "pytest.?cov|breaking" --type=md --max-count=20

Repository: kinde-oss/kinde-python-sdk

Length of output: 196

🌐 Web query:

pytest-cov v7 major version changes breaking compatibility

💡 Result:

Short summary — pytest-cov 7.0 (major) breaking / compatibility notes:

  • Dropped built‑in support for measuring subprocesses created by tests (the old .pth-based subprocess-measurement). If you relied on that, enable coverage’s subprocess patch via your .coveragerc (e.g. [run] patch = subprocess) and ensure coverage >= 7.10.6. [1][2]

  • Minimum coverage requirement increased (requires at least coverage 7.10.6). [1][3]

  • Packaging changed (metadata moved to pyproject.toml; build with hatchling) and some test deps removed (e.g. six) — this mainly affects downstream packagers/build tooling. [1]

References:
[1] pytest-cov changelog (7.0.0) — release notes.
[2] Example dependency-update notes summarizing v7 change (subprocess drop).
[3] Changelog mirrors listing requirement for coverage >= 7.10.6.

🌐 Web query:

coverage package dependency pytest-cov transitive

💡 Result:

Short answer: pytest-cov depends on the coverage package, so installing pytest-cov will pull coverage in transitively (and recent pytest-cov releases also require a minimum coverage version). (pypi.org)

Citations:

Ensure .coveragerc is configured for pytest-cov v7 subprocess measurement.

The pytest-cov v7 upgrade includes breaking changes: built-in subprocess measurement via .pth files was removed. If your tests spawn subprocesses, you must explicitly enable coverage's subprocess patch in .coveragerc (add [run] patch = subprocess). The explicit coverage>=7.10.6 requirement is correct—it's the minimum version mandated by pytest-cov v7, not redundant. Verify that your coverage configuration and test suite are compatible with these changes.

🤖 Prompt for AI Agents 
In requirements.txt around lines 26-27, the upgrade to pytest-cov v7 requires
enabling coverage's subprocess patch because built-in subprocess measurement via
.pth files was removed; update your .coveragerc to include a [run] section with
"patch = subprocess" (or set the equivalent env/pytest option) so coverage
measures subprocesses, ensure coverage>=7.10.6 remains in requirements, and
rerun the test suite to verify subprocess-spawned tests are now measured
correctly.

pytest-timeout>=2.2.0
black>=23.7.0
flake8>=6.1.0
Expand Down