Skip to content

fix: wrong selection coordinates on focus (iOS 16+) #1234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kirillzyusko wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: wrong selection coordinates on focus (iOS 16+) #1234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5d4c28e
fix: wrong selection coordinates on focus (iOS 16+)
kirillzyusko Dec 8, 2025
9527e07
fix: try to always update focused input layout
kirillzyusko Dec 17, 2025
dbbbceb
fix: catch selection change event only when keyboard appears
kirillzyusko Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ios/observers/FocusedInputObserver.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,9 @@ public class FocusedInputObserver: NSObject {
setupObservers()
// dispatch onSelectionChange on focus
if let textInput = responder as? UITextInput {
updateSelectionPosition(textInput: textInput, sendEvent: onSelectionChange)
DispatchQueue.main.async {
updateSelectionPosition(textInput: textInput, sendEvent: self.onSelectionChange)
}
}

syncUpLayout()
Expand Down
5 changes: 5 additions & 0 deletions src/components/KeyboardAwareScrollView/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,6 +295,11 @@ const KeyboardAwareScrollView = forwardRef<

lastSelection.value = e;

// pre iOS 16 case, when selection event delivered between `onStart` and `onMove` events
if (keyboardWillAppear.value) {
updateLayoutFromSelection();
}

if (e.target !== lastTarget) {
// ignore this event, because "focus changed" event handled in `useSmoothKeyboardHandler`
return;
Expand Down
Loading