Skip to content

adds destination_prefix_list_id in aws_route resource type #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 8, 2025
Merged

adds destination_prefix_list_id in aws_route resource type #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f93d17
adds destination_prefix_list_id in aws_route resource type
chiragtayal Aug 8, 2025
38dff77
fix the test case
chiragtayal Aug 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pkg/convertor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,9 @@ func computeResourceID(resource parser.TerraformResource) string {
case "aws_cloudwatch_log_stream":
return fmt.Sprintf("%s:%s", v("log_group_name"), v("name"))
case "aws_route":
if resource.AttributeValues["destination_cidr_block"] != "" {
if resource.AttributeValues["destination_prefix_list_id"] != "" {
return fmt.Sprintf("%s_%s", v("route_table_id"), v("destination_prefix_list_id"))
} else if resource.AttributeValues["destination_cidr_block"] != "" {
return fmt.Sprintf("%s_%s", v("route_table_id"), v("destination_cidr_block"))
} else {
return fmt.Sprintf("%s_%s", v("route_table_id"), v("destination_ipv6_cidr_block"))
Expand Down
20 changes: 20 additions & 0 deletions pkg/convertor_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,13 +480,32 @@ func Test_ComputeTerraformImportForResource(t *testing.T) {
SupportsImport: true,
},
},
{
name: "For aws_route_with_destination_prefix_list_id",
terraformResource: parser.TerraformResource{
Address: "aws_route.test",
Type: "aws_route",
AttributeValues: map[string]any{
"route_table_id": "rtb-656C65616E6F72",
"destination_prefix_list_id": "pl-12df45133",
"destination_cidr_block": "",
"destination_ipv6_cidr_block": "",
},
},
expected: TerraformImport{
ResourceAddress: "aws_route.test",
ResourceID: "rtb-656C65616E6F72_pl-12df45133",
SupportsImport: true,
},
},
{
name: "For aws_route_with_destination_cidr_block",
terraformResource: parser.TerraformResource{
Address: "aws_route.test",
Type: "aws_route",
AttributeValues: map[string]any{
"route_table_id": "rtb-656C65616E6F72",
"destination_prefix_list_id": "",
"destination_cidr_block": "10.42.0.0/16",
"destination_ipv6_cidr_block": "",
},
Expand All @@ -504,6 +523,7 @@ func Test_ComputeTerraformImportForResource(t *testing.T) {
Type: "aws_route",
AttributeValues: map[string]any{
"route_table_id": "rtb-656C65616E6F72",
"destination_prefix_list_id": "",
"destination_cidr_block": "",
"destination_ipv6_cidr_block": "2620:0:2d0:200::8/1",
},
Expand Down