Skip to content

Conversation

@dprotaso
Copy link
Contributor

No description provided.

@knative-prow knative-prow bot requested review from skonto and upodroid November 26, 2025 20:57
@knative-prow
Copy link

knative-prow bot commented Nov 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 26, 2025
@dprotaso
Copy link
Contributor Author

/assign @nader-ziada @linkvt

@codecov
Copy link

codecov bot commented Nov 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.96%. Comparing base (480e31d) to head (b426d9c).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1491   +/-   ##
=======================================
  Coverage   81.96%   81.96%           
=======================================
  Files          23       23           
  Lines        1519     1519           
=======================================
  Hits         1245     1245           
  Misses        180      180           
  Partials       94       94           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dprotaso
Copy link
Contributor Author

/retest

odd we're not actually testing the gateway api path

@linkvt
Copy link

linkvt commented Nov 27, 2025

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2025
@knative-prow knative-prow bot merged commit aba5370 into knative-extensions:main Nov 27, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants