-
Notifications
You must be signed in to change notification settings - Fork 271
Add --https flag for e2e tests #2076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This change introduces a --https flag similar to knative/serving#5157 to allow e2e tests to run correctly when the cluster is configured with defaultExternalScheme=https. Changes: - Add test/e2e/e2e_flags.go with --https flag infrastructure - Update domain_mapping_test.go to respect --https flag when determining expected URL schemes - Update test/README.md with documentation for the new flag The TestDomain test now adapts to cluster configuration: - Without --https: Expects HTTP for regular services, HTTPS for TLS services - With --https: Expects HTTPS for all services (matches defaultExternalScheme=https) This fixes the issue where TestDomain fails when defaultExternalScheme is set to https. Fixes: knative/serving#5157
Welcome @gouthamhusky! It looks like this is your first PR to knative/client 🎉 |
Hi @gouthamhusky. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: gouthamhusky The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Make the description more generic and concise
This change introduces a
--https
flag for e2e testspart of #1520
Changes:
test/e2e/e2e_flags.go
with --https flag infrastructuredomain_mapping_test.go
to respect --https flag when determining expected URL schemestest/README.md
with documentation for the new flagTesting: