Skip to content

Conversation

gouthamhusky
Copy link

@gouthamhusky gouthamhusky commented Oct 11, 2025

This change introduces a --https flag for e2e tests

part of #1520

Changes:

  • Add test/e2e/e2e_flags.go with --https flag infrastructure
  • Update domain_mapping_test.go to respect --https flag when determining expected URL schemes
  • Update test/README.md with documentation for the new flag

Testing:

  • Flag parsing works correctly
  • Tests compile without errors
  • Flag is passed through test script properly
  • Documentation updated

This change introduces a --https flag similar to knative/serving#5157
to allow e2e tests to run correctly when the cluster is configured
with defaultExternalScheme=https.

Changes:
- Add test/e2e/e2e_flags.go with --https flag infrastructure
- Update domain_mapping_test.go to respect --https flag when determining expected URL schemes
- Update test/README.md with documentation for the new flag

The TestDomain test now adapts to cluster configuration:
- Without --https: Expects HTTP for regular services, HTTPS for TLS services
- With --https: Expects HTTPS for all services (matches defaultExternalScheme=https)

This fixes the issue where TestDomain fails when defaultExternalScheme is set to https.

Fixes: knative/serving#5157
Copy link

linux-foundation-easycla bot commented Oct 11, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link

knative-prow bot commented Oct 11, 2025

Welcome @gouthamhusky! It looks like this is your first PR to knative/client 🎉

Copy link

knative-prow bot commented Oct 11, 2025

Hi @gouthamhusky. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 11, 2025
Copy link

knative-prow bot commented Oct 11, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gouthamhusky
Once this PR has been reviewed and has the lgtm label, please assign dprotaso for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from dsimansk and gauron99 October 11, 2025 20:58
@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant