add lang_header parameter for specify language header values in export #2643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nguage for header values in excel/csv export (you can have _xml header values and _default values for submits datas). If not set, lang arg override lang_header arg value. Need this PR : kobotoolbox/formpack#215
|
Edit: I moved my comment over to kobotoolbox/formpack#215 |
dorey
reviewed
Apr 29, 2020
kpi/models/import_export_task.py
Outdated
| group_sep = self.data.get('group_sep', '/') | ||
| translations = pack.available_translations | ||
| lang = self.data.get('lang', None) or next(iter(translations), None) | ||
| lang_header = self.data.get('lang_header', lang) or next(iter(translations), None) |
There was a problem hiding this comment.
Suggested change
| lang_header = self.data.get('lang_header', lang) or next(iter(translations), None) | |
| lang_header = self.data.get('lang_header', lang) |
because lang is the fallback value, and it's set in the line above, we don't need a second fallback value
… value for header_lang
|
PR was closed accidentally because we removed the underlying base branch. Please carry on the discussion! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add lang_header parameter. lang_header can be used for specify the language for header values in excel/csv export (you can have _xml header values and _default values for submits datas). If not set, lang arg override lang_header arg value. Need this PR : kobotoolbox/formpack#215