feat(api): add /api/v2/user-reports/ endpoint for superusers DEV-232 DEV-899
#6243
+3,228
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… caculated fields to the seralizer, add pagination, and only allow superusers to access endpoint
…ze-queries-for-subscriptions
RuthTurk
force-pushed
the
dev-899-optimize-queries-for-subscriptions
branch
from
507182e to
3f421d1
Compare
noliveleger
requested changes
Sep 17, 2025
noliveleger
reviewed
Sep 18, 2025
noliveleger
requested changes
Oct 4, 2025
noliveleger
requested changes
Oct 4, 2025
noliveleger
changed the title
/user-reports/ endpoint for superusers/api/v2/user-reports/ endpoint for superusers
RuthTurk
changed the title
/api/v2/user-reports/ endpoint for superusers/api/v2/user-reports/ endpoint for superusers DEV-232 DEV-899
9 tasks
noliveleger
requested changes
Oct 9, 2025
kobo/apps/user_reports/tasks.py
Outdated
| lock_timeout = settings.CELERY_LONG_RUNNING_TASK_TIME_LIMIT + 60 | ||
| lock = cache.lock(cache_key, timeout=lock_timeout) | ||
| if not lock.acquire(blocking=False, blocking_timeout=0): | ||
| logging.error('Task is already running') |
There was a problem hiding this comment.
This was for debugging purpose. I'm wondering if we should keep this. It will probably flood Sentry logs for nothing. Maybe we can change it for logging.info(' Nothing to do, task is already running!)?
What do you think?
Comment on lines
237
to
239
| with connection.cursor() as cursor: | ||
| cursor.execute('REFRESH MATERIALIZED VIEW user_reports_userreportsmv;') | ||
|
|
There was a problem hiding this comment.
Can we use an utility function to avoid repeating thse two lines several times?
Comment on lines
30
to
34
| # Refresh materialized view | ||
| with connection.cursor() as cursor: | ||
| cursor.execute( | ||
| 'REFRESH MATERIALIZED VIEW CONCURRENTLY user_reports_userreportsmv;' | ||
| ) |
There was a problem hiding this comment.
We can probably use the same helper here and in the tests.
| ) FILTER (WHERE sub.id IS NOT NULL), | ||
| '[]'::jsonb | ||
| )::text AS subscriptions | ||
| FROM auth_user au |
There was a problem hiding this comment.
We probably want to remove anonymous user from the list (e.g. auth_user.id != settings.ANONYMOUS_ID)
…refresh materialized view, improve logging comment
…ze-queries-for-subscriptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Checklist
<type>(<scope>)<!>: <title> DEV-1234Front endand/orBack endorworkflow📣 Summary
Add a new superuser-only endpoint,
/api/v2/user-reports/, to access and filter all user usage data.💭 Notes
user_reportsrefresh-user-report-snapshotruns every 30 minutes and works to update the data in batches👀 Preview steps
user_reports/api/v2/user-reports/and get a 403 Forbidden errorrefresh-user-report-snapshot/api/v2/user-reports/and get 200 with all the users and data