Accum tests and e2e test #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
…oj#232) Signed-off-by: sapkota-aayush <[email protected]>
- Fixed dictionary iteration issue in stream_send_eof method that was causing 'RuntimeError: dictionary changed size during iteration' - Fixed None watermark comparison issues in write_to_global_queue method - Fixed None watermark/event_time conversion to protobuf timestamp - Added proper null checks for watermark and event_time handling - Tests now run without runtime errors and produce expected message count The main fixes: 1. Create copy of dictionary keys before iteration in stream_send_eof 2. Add null checks before watermark comparison and protobuf conversion 3. Handle None values properly in Message watermark/event_time fields Tests are now passing the core functionality (message processing) but EOF handling still needs work. Signed-off-by: srao12 <[email protected]>
- Fix missing default value in AccumulatorRequest constructor - Add watermark parameter handling in AccumulatorRequest - Improve test structure and remove debug test file - Fix task_manager.py to handle EOF counting properly - All 253 tests now pass successfully Signed-off-by: srao12 <[email protected]>
Signed-off-by: srao12 <[email protected]>
Signed-off-by: srao12 <[email protected]>
Signed-off-by: srao12 <[email protected]>
Signed-off-by: srao12 <[email protected]>
Signed-off-by: srao12 <[email protected]>
Signed-off-by: srao12 <[email protected]>
Signed-off-by: srao12 <[email protected]>
Signed-off-by: srao12 <[email protected]>
Signed-off-by: srao12 <[email protected]>
Signed-off-by: srao12 <[email protected]>
Signed-off-by: srao12 <[email protected]>
Signed-off-by: srao12 <[email protected]>
Signed-off-by: srao12 <[email protected]>
Signed-off-by: srao12 <[email protected]>
Signed-off-by: srao12 <[email protected]>
Signed-off-by: srao12 <[email protected]>
Signed-off-by: Takashi Menjo <[email protected]>
Signed-off-by: srao12 <[email protected]>
- Add tests for OPEN, APPEND, and CLOSE window operations - Test standard flow (OPEN→APPEND→CLOSE), append-only, and mixed operation patterns - Add multi-key processing and error handling test scenarios Signed-off-by: srao12 <[email protected]>
Signed-off-by: srao12 <[email protected]>
Signed-off-by: srao12 <[email protected]>
Signed-off-by: srao12 <[email protected]>
Signed-off-by: srao12 <[email protected]>
added 3 commits
July 30, 2025 00:47
Signed-off-by: srao12 <[email protected]>
Signed-off-by: srao12 <[email protected]>
Signed-off-by: srao12 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.