Improvements on failure recovery #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The wrong error variable was used when reporting some mount errors
This enables more careful treatment of volume removal: we begin by making sure that a volume's mountpoint no longer exists or, if it does, we unmount it (force+detach). If that succeeds, we can then safely remove the volume (which would fail otherwise, leaving the volume in an inconsistent state, neither allowing to mount it nor remove it). If unmounting the mountpoint fails, we refuse to do anything else to the volume, leaving it exactly in the state it was before. Update relevant parts of code accordingly. Require in tests that volumes are removed even when an overlay remains mounted.
- Factor out the volume activation and deactivation to separate functions (I am not sure if it makes much difference but seems a bit cleaner); - Define the order in which activation/deactivation attempt shall be performed, with the expect guarantees (see the "conceptual note"); - Update comments and log/error messages according to that new principle; - Tests: remove the volatility requirement after the volume is messed with: unfortunately, there does not seem to be a way to guarantee volatility properties if we are unable to indicate that the last container has exited; - Tests: enable the previously skipped test. Co-authored-by: AnderG <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the way docker-on-top handles failures to perform some operations with volumes. Partially inspired by changes in #20