add CI test for Cygwin #834
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add cygwin testing
|
I added a cygwin matrix to test 32-bit also (though 32-bit cygwin is no longer supported upstream): https://github.com/jeremyd2019/ksh/actions/runs/13906198215 |
1 task
jeremyd2019
commented
May 15, 2025
| } | ||
| cygwin_conv_to_win32_path(path, buf); | ||
| return strlen(buf); | ||
| return cygwin_conv_path(CCP_POSIX_TO_WIN_A | CCP_ABSOLUTE, path, buf, siz); |
There was a problem hiding this comment.
Looking back on this now, this is wrong per the specification in the comments above, vs the documentation of cygwin_conv_path.
For cygwin_conv_path, if size is 0, buf may be NULL and it will return the size of buffer required. If size is not 0, it will return 0 on success or -1 on error (error including ENOSPC if size is too small to hold the result).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this can be a start to figure out the issues
@xeiavicaflashrepository @gisburn