Implement skipInvalidResources for syslog-ng logging #2116
Conversation
Copilot
AI
changed the title
Co-authored-by: csatib02 <[email protected]>
Signed-off-by: Bence Csati <[email protected]>
csatib02
force-pushed
the
copilot/fix-7d3b6ea5-1612-4c73-b160-15fd29dec4c1
branch
from
fe29527 to
1d505a4
Compare
| for _, cf := range in.ClusterFlows { | ||
| if err := validateClusterOutputs(clusterOutputRefs, client.ObjectKeyFromObject(&cf).String(), cf.Spec.GlobalOutputRefs, cf.Kind); err != nil { | ||
| if in.SkipInvalidResources { | ||
| // Skip this cluster flow and continue with the next one |
There was a problem hiding this comment.
@copilot add an error log here that we skipped this resource
There was a problem hiding this comment.
Added error logging in commit 7a1f2c3. The code now logs "skipping invalid SyslogNGClusterFlow" with the resource name and namespace when an invalid cluster flow is skipped.
| } | ||
| if flowErrs != nil { | ||
| if in.SkipInvalidResources { | ||
| // Skip this flow and continue with the next one |
There was a problem hiding this comment.
@copilot add an error log here about the skipped resource
There was a problem hiding this comment.
Added error logging in commit 7a1f2c3. The code now logs "skipping invalid SyslogNGFlow" with the resource name and namespace when an invalid flow is skipped.
| for _, cf := range in.ClusterFlows { | ||
| if err := validateClusterOutputs(clusterOutputRefs, client.ObjectKeyFromObject(&cf).String(), cf.Spec.GlobalOutputRefs, cf.Kind); err != nil { | ||
| if in.SkipInvalidResources { | ||
| // Skip this cluster flow and continue with the next one |
There was a problem hiding this comment.
@copilot add an error log here about the skipped resource
There was a problem hiding this comment.
Added error logging in commit 7a1f2c3. The code now logs "skipping invalid SyslogNGClusterFlow" with the resource name and namespace when an invalid cluster flow is skipped.
| } | ||
| if flowErrs != nil { | ||
| if in.SkipInvalidResources { | ||
| // Skip this flow and continue with the next one |
There was a problem hiding this comment.
@copilot add an error log here about the skipped resource
There was a problem hiding this comment.
Added error logging in commit 7a1f2c3. The code now logs "skipping invalid SyslogNGFlow" with the resource name and namespace when an invalid flow is skipped.
Co-authored-by: csatib02 <[email protected]>
Implementation Complete: skipInvalidResources for syslog-ng
✅ All tasks completed successfully
Summary
Successfully implemented
skipInvalidResourcessupport for syslog-ng logging to match the existing behavior in fluentd. When this flag is enabled in the Logging resource spec, invalid SyslogNGFlows and SyslogNGClusterFlows (e.g., those referencing non-existent outputs) are skipped during configuration rendering instead of causing the entire reconciliation to fail.Changes Made:
SkipInvalidResourcesfield toconfig.Inputstruct inpkg/sdk/logging/model/syslogng/config/config.goconfigRendererfunction to:SkipInvalidResourcesis trueSkipInvalidResourcesis truecontrollers/logging/logging_controller.goto pass the flag and logger from Logging specconfig_test.go:Recent Updates:
Loggerfield toInputstruct to enable error logginggithub.com/go-logr/logrpackageTesting Results:
Behavior:
The implementation works exactly like the fluentd version:
skipInvalidResources: truein the Logging spec, invalid flows/clusterflows are skipped with error logsskipInvalidResources: false(default), errors are accumulated and returned, causing reconciliation to fail✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.