Fix array of arrays handling #364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clux
approved these changes
Sep 14, 2025
Comment on lines
+1433
to
+1536
| let map = &root.members[0]; | ||
| assert_eq!(map.name, "mounts"); | ||
| assert_eq!(map.type_, "Option<Vec<Vec<String>>>"); |
There was a problem hiding this comment.
test makes sense based on the schema and as a sanity, it does seem to match what i find in the wild for the crd
Signed-off-by: Clément Hamada <[email protected]>
ClemaX
force-pushed
the
fix/array-of-array
branch
from
a8b0d02 to
3710a70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing
Vec<{}>formatting to array of arrays type.Fixes #315 .
Supersedes #316 .