Skip to content

Conversation

@ClemaX
Copy link
Collaborator

@ClemaX ClemaX commented Sep 12, 2025

Add a missing match case for number in resolve_additional_properties to handle maps with type number.

Signed-off-by: Clément Hamada <[email protected]>
Copy link
Member

@clux clux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot!

@clux clux merged commit cc70d98 into kube-rs:main Sep 14, 2025
5 checks passed
@clux
Copy link
Member

clux commented Sep 14, 2025

Sent bothtwo of your last fixes out in 0.22.2. Just now seeing the other PRs sorry.

btw i'm amazed you are finding so many edge cases so quickly. have you been looking at the kube-custom-resources library?

@clux
Copy link
Member

clux commented Sep 14, 2025

sent you an you as a collaborator if you want some more access or be listed in the org. feel free to accept/decline as you wish, it's largely symbolic; no commitments expected for it, but at this point you know the internals of this project as well as anyone. thanks a lot for all your contributions.

@ClemaX
Copy link
Collaborator Author

ClemaX commented Sep 14, 2025

Yes exactly. I wanted to use their kcr_postgresql_cnpg_io bindings crate, but the Cluster resource was missing due to being ignored. After attempting to generate it myself, I noticed the first issues with the map of arrays.

I am preparing a pull request to add the postgresql resources that used to generate invalid code and noticed that other CRDs had similar issues due to these edge-cases and attempted to fix those too.

With these fixes the kube-custom-resources will be able to generate many resources that needed to be ignored until now.

Thank you for the invitation. I'm happy to accept it and looking forward to supporting the project however I can! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants