Skip to content

Conversation

clux
Copy link
Member

@clux clux commented Jul 18, 2025

started out as a PR to try out let-chains, but found that it solves most of the the ergonomic problem with the wait API that I tried to solve earlier in #1498

it's not quite as elegant as #1498, but it also doesn't come with any of the problems and is non-breaking.

Unfortunately it does require rust2024 on rustfmt which means it does require a lot of incidental changes.

The first commit is the human generated part, the second is from cargo fmt (third to get CI to accept it).


It's a little early for this because it requires Rust 1.88 (current latest), and we should wait a version or two before making a requirement.

But if the general setup (outlined in the first commit) is acceptable, I'll rebase at 1.90.

clux added 3 commits July 18, 2025 15:40
started out as a PR to try out let-chains, but found that it solves
the ergonomic problem with the wait API that I tried to solve earlier in #1498

Signed-off-by: clux <[email protected]>
Copy link

codecov bot commented Jul 18, 2025

Codecov Report

Attention: Patch coverage is 84.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 75.1%. Comparing base (6590ea9) to head (d9571ab).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
kube-client/src/client/auth/mod.rs 16.7% 5 Missing ⚠️
kube-core/src/schema.rs 0.0% 1 Missing ⚠️
kube-derive/src/custom_resource.rs 0.0% 1 Missing ⚠️
kube-derive/src/resource.rs 0.0% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1792     +/-   ##
=======================================
- Coverage   75.2%   75.1%   -0.0%     
=======================================
  Files         84      84             
  Lines       7791    7791             
=======================================
- Hits        5853    5850      -3     
- Misses      1938    1941      +3     
Files with missing lines Coverage Δ
kube-client/src/api/core_methods.rs 72.4% <ø> (ø)
kube-client/src/api/entry.rs 77.1% <ø> (ø)
kube-client/src/api/mod.rs 65.4% <ø> (ø)
kube-client/src/api/portforward.rs 0.0% <ø> (ø)
kube-client/src/api/remote_command.rs 42.1% <ø> (ø)
kube-client/src/api/subresource.rs 51.8% <ø> (ø)
kube-client/src/api/util/csr.rs 66.7% <ø> (ø)
kube-client/src/api/util/mod.rs 93.2% <ø> (ø)
kube-client/src/client/auth/oauth.rs 0.0% <ø> (ø)
kube-client/src/client/auth/oidc.rs 56.4% <ø> (ø)
... and 52 more

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant