examples: update warp, handle tls in admission_controller
#1833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds a dev-dependency to examples on `tokio-rustls`, the `server` feature to `hyper` and the `service` feature to `hyper-util` Signed-off-by: Elizabeth Hollyburn <[email protected]>
|
Hey, thanks a lot for this. Yeah, I agree this is a lot 😅 (Don't worry about the CI issues, being fixed separately) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1808. tried to keep it minimal without panicking in the main loop, but it still wound up pretty big. unwrapping in the loop only saves a dozenish lines, it's just kind of a lot to handle tls manually. it'd be nice to be able to break this out, if any other examples used warp