-
Couldn't load subscription status.
- Fork 1.8k
Optional Runtime Parameters Fix #12377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optional Runtime Parameters Fix #12377
Conversation
|
Hi @sduvvuri1603. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
🚫 This command cannot be processed. Only organization members or owners can use the commands. |
2ca0cad to
c172b70
Compare
|
/ok-to-test |
|
Approvals successfully granted for pending runs. |
2d62972 to
f4fc7aa
Compare
|
/ok-to-test |
|
Approvals successfully granted for pending runs. |
|
/ok-to-test |
|
Approvals successfully granted for pending runs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are two files located at the root level of the directory - secrets_configmaps_pipeline.py and secrets_configmaps_pipeline.yaml - these should be located in a test file directory of some kind - likely test_data/sdk_compiled_pipelines, depending on where you meant to test them
test_data/sdk_compiled_pipelines/valid/critical/missing_kubernetes_optional_inputs.yaml
Show resolved
Hide resolved
|
/ok-to-test |
|
Approvals successfully granted for pending runs. |
d79cd63 to
a4b7d8a
Compare
|
/ok-to-test |
|
Approvals successfully granted for pending runs. |
c9b2fa3 to
6f3ca2d
Compare
|
/ok-to-test |
|
Approvals successfully granted for pending runs. |
6f3ca2d to
08eba17
Compare
Signed-off-by: sduvvuri1603 <[email protected]>
Signed-off-by: sduvvuri1603 <[email protected]>
Signed-off-by: sduvvuri1603 <[email protected]>
Signed-off-by: sduvvuri1603 <[email protected]>
Signed-off-by: sduvvuri1603 <[email protected]>
Signed-off-by: sduvvuri1603 <[email protected]>
08eba17 to
15a56da
Compare
|
/ok-to-test |
Signed-off-by: sduvvuri1603 <[email protected]>
|
/ok-to-test |
|
Approvals successfully granted for pending runs. |
|
/lgtm |
|
@sduvvuri1603 can you please rebase? |
Signed-off-by: Sruthi Duvvuri <[email protected]>
|
/ok-to-test |
|
Approvals successfully granted for pending runs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hbelmiro, zazulam The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of changes
ErrResolvedParameterNullas skip for optional Kubernetes inputs and ensure the driver’s pod spec patch includes certs.missing_kubernetes_optional_inputspipeline and regenerated compiler goldens covering secrets/configmaps, node selector, node affinity, and tolerations missing-input scenarios.Testing
ginkgo -v ./backend/test/compiler -- -createGoldenFiles=true -updateCompiledFiles=true(pass)Resolves: #11899