Skip to content

Conversation

@sduvvuri1603
Copy link
Contributor

Description of changes

  • Treat ErrResolvedParameterNull as skip for optional Kubernetes inputs and ensure the driver’s pod spec patch includes certs.
  • Add missing_kubernetes_optional_inputs pipeline and regenerated compiler goldens covering secrets/configmaps, node selector, node affinity, and tolerations missing-input scenarios.

Testing

  • Manual: ran node selector, affinity, secrets/configmaps pipelines in Kind (no launcher crashes).
  • ginkgo -v ./backend/test/compiler -- -createGoldenFiles=true -updateCompiledFiles=true (pass)

Resolves: #11899

@google-oss-prow
Copy link

Hi @sduvvuri1603. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link

🚫 This command cannot be processed. Only organization members or owners can use the commands.

@google-oss-prow google-oss-prow bot requested review from HumairAK and zazulam October 17, 2025 18:07
@sduvvuri1603 sduvvuri1603 force-pushed the debug/secret-configmap branch from 2ca0cad to c172b70 Compare October 17, 2025 18:12
@alyssacgoins
Copy link
Contributor

/ok-to-test

@github-actions
Copy link

Approvals successfully granted for pending runs.

@mprahl
Copy link
Collaborator

mprahl commented Oct 20, 2025

/ok-to-test

@github-actions
Copy link

Approvals successfully granted for pending runs.

@alyssacgoins
Copy link
Contributor

/ok-to-test

@github-actions
Copy link

Approvals successfully granted for pending runs.

Copy link
Contributor

@alyssacgoins alyssacgoins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two files located at the root level of the directory - secrets_configmaps_pipeline.py and secrets_configmaps_pipeline.yaml - these should be located in a test file directory of some kind - likely test_data/sdk_compiled_pipelines, depending on where you meant to test them

@alyssacgoins
Copy link
Contributor

/ok-to-test

@github-actions
Copy link

Approvals successfully granted for pending runs.

@sduvvuri1603 sduvvuri1603 force-pushed the debug/secret-configmap branch from d79cd63 to a4b7d8a Compare October 23, 2025 17:48
@alyssacgoins
Copy link
Contributor

/ok-to-test

@github-actions
Copy link

Approvals successfully granted for pending runs.

@sduvvuri1603 sduvvuri1603 force-pushed the debug/secret-configmap branch 2 times, most recently from c9b2fa3 to 6f3ca2d Compare October 23, 2025 22:43
@alyssacgoins
Copy link
Contributor

/ok-to-test

@github-actions
Copy link

Approvals successfully granted for pending runs.

@sduvvuri1603 sduvvuri1603 force-pushed the debug/secret-configmap branch from 6f3ca2d to 08eba17 Compare October 24, 2025 16:21
@sduvvuri1603 sduvvuri1603 force-pushed the debug/secret-configmap branch from 08eba17 to 15a56da Compare October 24, 2025 16:23
@alyssacgoins
Copy link
Contributor

/ok-to-test

@sduvvuri1603 sduvvuri1603 marked this pull request as ready for review October 24, 2025 17:43
@google-oss-prow google-oss-prow bot requested a review from hbelmiro October 24, 2025 17:43
Signed-off-by: sduvvuri1603 <[email protected]>
@alyssacgoins
Copy link
Contributor

/ok-to-test

@github-actions
Copy link

Approvals successfully granted for pending runs.

@alyssacgoins
Copy link
Contributor

/lgtm

@hbelmiro
Copy link
Contributor

@sduvvuri1603 can you please rebase?

@google-oss-prow google-oss-prow bot removed the lgtm label Oct 27, 2025
@hbelmiro
Copy link
Contributor

/ok-to-test

@github-actions
Copy link

Approvals successfully granted for pending runs.

Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@zazulam
Copy link
Collaborator

zazulam commented Oct 28, 2025

/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hbelmiro, zazulam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit ff97283 into kubeflow:master Oct 28, 2025
117 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] Kubernetes platform runtime parameters don't work for optional case

5 participants