chore: update py image refs to 3.11 #12383
Conversation
google-oss-prow
bot
requested review from
DharmitD,
HumairAK,
alyssacgoins,
droctothorpe,
mprahl and
nsingla
|
Thanks for tackling this, @zazulam ! LGTM. Will approve once rebased and tests are passing! 👍 |
|
Should we have a couple of test pipeline IR with older python version until we completely migrate to 3.11? |
@nsingla My thought is having the test matrix for the |
zazulam
force-pushed
the
py-version-bump
branch
2 times, most recently
from
02eb71f to
d151941
Compare
Signed-off-by: zazulam <[email protected]>
Signed-off-by: zazulam <[email protected]>
zazulam
force-pushed
the
py-version-bump
branch
from
d151941 to
051cc42
Compare
Signed-off-by: zazulam <[email protected]>
zazulam
force-pushed
the
py-version-bump
branch
from
051cc42 to
7f4e0a6
Compare
Signed-off-by: zazulam <[email protected]>
| # testing reinstalling kfp package from source with no deps | ||
| - name: Reinstall kfp from source with no deps | ||
| id: reinstall-kfp | ||
| shell: bash | ||
| if: ${{ steps.install-kfp-kubernetes.outcome == 'success' }} | ||
| working-directory: ./sdk/python | ||
| run: | | ||
| pip install . -I --no-deps |
There was a problem hiding this comment.
Added this since the previous section was not actually using the source install for the kfp sdk, see here for the error prior to this add.
| self.assertEqual( | ||
| component.component_spec.implementation.container.image, | ||
| 'python:3.9') | ||
| # TODO: uncomment once PR #12383 is merged since this is checking against a version on master | ||
| # self.assertEqual( | ||
| # component.component_spec.implementation.container.image, | ||
| # 'python:3.11') |
There was a problem hiding this comment.
commenting for reference for others
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: droctothorpe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
merged commit 2ccd057
into
kubeflow:master
3 participants
Description of your changes:
Modified all python image references to now point to python 3.11.
As discussed offline, we will keep 3.9 as the lowest working python installation for KFP and keep it the lower end of the python testing matrix since some users may be slow to upgrade their setups.
Updated the warning to say:
KFP will drop support for Python 3.9 on October 1, 2026. To use new versions of the KFP SDK after that date, you will need to upgrade to Python >= 3.10. See https://devguide.python.org/versions/ for more details.Pushed it out a year, I'm open to updating the date to whatever others think would be best.
Checklist: