-
Notifications
You must be signed in to change notification settings - Fork 61
feat: Use WMI to implement Disk API to reduce PowerShell overhead (library version) #385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Use WMI to implement Disk API to reduce PowerShell overhead (library version) #385
Conversation
Hi @laozc. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
63b4aaf
to
4911de6
Compare
/cc @mauriciopoppe |
/cc @andyzhangx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's great that the tests are passing, I think the description should be updated to link to the binary implementation #376
/lgtm
4911de6
to
ab5c26a
Compare
ab5c26a
to
f8cf2f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, laozc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
986607e
into
kubernetes-csi:library-development
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR leverages of WMI interfaces to replace the PowerShell functions for Disk APIs,
It improves the overall performance of csi-proxy.
Partially for #193
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Refer to #376 for the change for standalone process.
Does this PR introduce a user-facing change?: