Skip to content

Conversation

mauriciopoppe
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind documentation

What this PR does / why we need it:

Changelog v2.0.0-alpha.2

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. labels Sep 16, 2025
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 16, 2025
@mauriciopoppe
Copy link
Member Author

@k8s-ci-robot k8s-ci-robot requested review from andyzhangx and laozc and removed request for carlory and sunnylovestiramisu September 16, 2025 01:11
@andyzhangx
Copy link
Member

@laoc one ut is failing, could you take a look?

2025-09-16T01:15:18.5321606Z === RUN   TestSystem/GetBIOSSerialNumber
2025-09-16T01:15:18.5429993Z 2025/09/16 01:15:18 [WMI] QueryInstances [SELECT SerialNumber FROM CIM_BIOSElement]=> [1]
2025-09-16T01:15:18.5665951Z     system_test.go:29: 
2025-09-16T01:15:18.5666930Z         	Error Trace:	system_test.go:29
2025-09-16T01:15:18.5667972Z         	Error:      	Expected nil, but got: &exec.Error{Name:"wmic", Err:(*errors.errorString)(0x140449d40)}
2025-09-16T01:15:18.5669707Z         	Test:       	TestSystem/GetBIOSSerialNumber

@andyzhangx
Copy link
Member

@laoc one ut is failing, could you take a look?

2025-09-16T01:15:18.5321606Z === RUN   TestSystem/GetBIOSSerialNumber
2025-09-16T01:15:18.5429993Z 2025/09/16 01:15:18 [WMI] QueryInstances [SELECT SerialNumber FROM CIM_BIOSElement]=> [1]
2025-09-16T01:15:18.5665951Z     system_test.go:29: 
2025-09-16T01:15:18.5666930Z         	Error Trace:	system_test.go:29
2025-09-16T01:15:18.5667972Z         	Error:      	Expected nil, but got: &exec.Error{Name:"wmic", Err:(*errors.errorString)(0x140449d40)}
2025-09-16T01:15:18.5669707Z         	Test:       	TestSystem/GetBIOSSerialNumber

nvm, it would be fixed by #408

Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 16, 2025
@mauriciopoppe mauriciopoppe force-pushed the changelog-library-development branch from 64f96be to 403930a Compare September 17, 2025 00:07
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 17, 2025
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 17, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, mauriciopoppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [andyzhangx,mauriciopoppe]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8700f76 into kubernetes-csi:library-development Sep 17, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants