-
Notifications
You must be signed in to change notification settings - Fork 621
✨ feat: Support setting EKS authentication mode #5578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
d224304
092811a
b289e83
32efafb
52d0e7c
277cd1a
7b51517
67241e7
f5554f1
910914e
7cbcc9f
d9d523c
0b3fa84
d567755
9155ce4
7298085
af050cb
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -79,6 +79,21 @@ var ( | |
EKSTokenMethodAWSCli = EKSTokenMethod("aws-cli") | ||
) | ||
|
||
// EKSAuthenticationMode defines the authentication mode for the cluster | ||
type EKSAuthenticationMode string | ||
|
||
var ( | ||
// EKSAuthenticationModeConfigMap indicates that only `aws-auth` ConfigMap will be used for authentication | ||
EKSAuthenticationModeConfigMap = EKSAuthenticationMode("CONFIG_MAP") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It would be good if we used values like:
We generally try not to have direct copies of the values like this as all caps is a bit jarring in the manifests. It would mean we'd need to add a "conversion" function. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @joshfrench Would you get a chance to make this change so we can merge this PR? |
||
|
||
// EKSAuthenticationModeAPI indicates that only AWS Access Entries will be used for authentication | ||
EKSAuthenticationModeAPI = EKSAuthenticationMode("API") | ||
|
||
// EKSAuthenticationModeAPIAndConfigMap indicates that both `aws-auth` ConfigMap and AWS Access Entries will | ||
// be used for authentication | ||
EKSAuthenticationModeAPIAndConfigMap = EKSAuthenticationMode("API_AND_CONFIG_MAP") | ||
) | ||
|
||
var ( | ||
// DefaultEKSControlPlaneRole is the name of the default IAM role to use for the EKS control plane | ||
// if no other role is supplied in the spec and if iam role creation is not enabled. The default | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Uh oh!
There was an error while loading. Please reload this page.