Skip to content

Add Azure Linux 3 prow template for testing #5829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 18, 2025
Merged

Add Azure Linux 3 prow template for testing #5829

merged 1 commit into from
Sep 18, 2025
+3,272 −3

Conversation

willie-yao
Copy link
Contributor

@willie-yao willie-yao commented Aug 19, 2025 •
edited
Loading

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This PR adds templates that test Azure Linux 3, both a regular test and a conformance test.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • cherry-pick candidate

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 19, 2025
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 19, 2025
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 20, 2025
@codecov Codecov
Copy link

codecov bot commented Aug 22, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.94%. Comparing base (b7c1f0d) to head (836cc51).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5829   +/-   ##
=======================================
  Coverage   46.94%   46.94%           
=======================================
  Files         279      279           
  Lines       29687    29687           
=======================================
  Hits        13936    13936           
  Misses      14938    14938           
  Partials      813      813

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@willie-yao willie-yao force-pushed the test-azl3-2 branch 7 times, most recently from 018d29a to 16ab1d9 Compare August 23, 2025 01:39
@willie-yao willie-yao changed the title WIP [DO_NOT_MERGE]: Change default gallery to azl3 WIP: Add Azure Linux 3 prow template for testing Aug 24, 2025
@willie-yao willie-yao force-pushed the test-azl3-2 branch 2 times, most recently from 6767a03 to 84c9010 Compare August 25, 2025 17:13
@k8s-ci-robot k8s-ci-robot removed the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 25, 2025
@willie-yao willie-yao force-pushed the test-azl3-2 branch 2 times, most recently from 761211d to 309ade3 Compare September 13, 2025 00:23
@willie-yao
Copy link
Contributor Author

/hold cancel
Should be ready for review again! Got specific iptable configs setup @mboersma

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 13, 2025
@willie-yao willie-yao force-pushed the test-azl3-2 branch 9 times, most recently from b9c9a50 to d2864e4 Compare September 17, 2025 16:26
@willie-yao
Copy link
Contributor Author

/test pull-cluster-api-provider-azure-conformance-azl3-with-ci-artifacts
/test pull-cluster-api-provider-azure-e2e-optional

@willie-yao
Copy link
Contributor Author

/retest

mboersma
mboersma reviewed Sep 17, 2025
View reviewed changes
templates/test/ci/prow-azl3/patches/controller-manager.yaml
set -o errexit

# Install ca-certificates packages for Azure Linux
tdnf install -y ca-certificates ca-certificates-legacy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This setup looks reasonable to me. We should move some of this to the image-builder ansible scripts for Azure Linux--I'll create an issue or PR once this merges.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I figured out most of these ips from trial and error. I tried using netstat but there were more ips I needed to enable from what that told me.

mboersma
mboersma approved these changes Sep 18, 2025
View reviewed changes
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

The -optional e2e failure seems unrelated.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 18, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 65b2a1e561633b40fa3d04162e57a7161aeb07c2

@mboersma
Copy link
Contributor

/test pull-cluster-api-provider-azure-e2e-optional

@willie-yao
Copy link
Contributor Author

The -optional e2e failure seems unrelated.

Yeah I'm not sure what's going on. I'm running it as it includes the azl3 spec. Kinda weird it keeps failing

@willie-yao
Copy link
Contributor Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: willie-yao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2025
@k8s-ci-robot k8s-ci-robot merged commit 9db12dd into kubernetes-sigs:main Sep 18, 2025
32 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in CAPZ Planning Sep 18, 2025
@mboersma mboersma mentioned this pull request Sep 18, 2025
Merged
@nojnhuh nojnhuh added this to the v1.22 milestone Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mboersma mboersma mboersma approved these changes

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@nojnhuh nojnhuh Awaiting requested review from nojnhuh

Assignees

@mboersma mboersma

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
CAPZ Planning
Status: Done
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.
4 participants
@willie-yao @k8s-ci-robot @mboersma @nojnhuh