Fix revive package name conventions #2464

mayuka-c · 2025-08-19T15:07:05Z

What this PR does / why we need it:
This PR addresses the revive package naming convention issue

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2458

Special notes for your reviewer:
/kind cleanup
/area provider/ibmcloud

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
This PR is for fixing the linting issue.

Release note:

Fix revive package name conventions

Validation

After running make lint

INFO [runner] linters took 5.793821833s with stages: goanalysis_metalinter: 5.771707958s 0 issues. INFO File cache stats: 3 entries of total size 17.5KiB INFO Memory: 72 samples, avg is 1216.4MB, max is 2175.7MB INFO Execution took 7.086381416s

netlify · 2025-08-19T15:07:12Z

✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name	Link
🔨 Latest commit	`e2aeb43`
🔍 Latest deploy log	https://app.netlify.com/projects/kubernetes-sigs-cluster-api-ibmcloud/deploys/68ad21b0365e910008317621
😎 Deploy Preview	https://deploy-preview-2464.cluster-api-ibmcloud.sigs.k8s.io
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

k8s-ci-robot · 2025-08-19T15:07:15Z

Welcome @mayuka-c!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-ibmcloud 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-ibmcloud has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2025-08-19T15:07:15Z

Hi @mayuka-c. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

kishen-v · 2025-08-19T15:32:12Z

/ok-to-test

Prajyot-Parab · 2025-08-21T18:36:31Z

cloud/scope/powervs_cluster.go

@@ -49,16 +49,16 @@ import (
 	v1beta1patch "sigs.k8s.io/cluster-api/util/deprecated/v1beta1/patch" //nolint:staticcheck

 	infrav1 "sigs.k8s.io/cluster-api-provider-ibmcloud/api/v1beta2"
+	genUtil "sigs.k8s.io/cluster-api-provider-ibmcloud/genutil"


why genUtil and not use genutil as it is without alias?

Done, I have removed the named import. Thanks!

Prajyot-Parab · 2025-08-21T18:41:34Z

internal/webhooks/ibmpowervscluster.go

@@ -35,7 +35,7 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/webhook/admission"

 	infrav1 "sigs.k8s.io/cluster-api-provider-ibmcloud/api/v1beta2"
-	genUtil "sigs.k8s.io/cluster-api-provider-ibmcloud/util"
+	genUtil "sigs.k8s.io/cluster-api-provider-ibmcloud/genutil"


why genUtil and not use genutil as it is without alias?

Prajyot-Parab · 2025-08-21T18:48:34Z

pkg/cloud/services/pagingutils/paging.go

missing supporting doc.go

Since there was only single file, I had added the package comment in the same file. Now I have created doc.go and moved the package comment there

Most of the code under pkg/cloud/services/ are related to the one talking to the cloud, can we move this to somewhere else like pkg/utils and rename fix the naming aspect.

I have moved the pagining utils under pkg/ dir. Thanks!

Prajyot-Parab · 2025-08-21T19:04:33Z

cmd/capibmadm/pointer/pointer.go

@@ -0,0 +1,54 @@
+/*
+Copyright 2023 The Kubernetes Authors.


Suggested change

Copyright 2023 The Kubernetes Authors.

Copyright 2025 The Kubernetes Authors.

Done thanks

mkumatag · 2025-08-22T05:47:13Z

genutil/doc.go

-// Package utils implements utils code.
-package utils
+// Package genutil implements general utility code.
+package genutil


let us avoid having anything in the root folder, see if we can move this under pkg to internal

Have moved it under internal

mkumatag

overall LGTM with a minor comment

mkumatag · 2025-08-25T08:25:17Z

pkg/cloud/services/pagingutils/paging.go

Most of the code under pkg/cloud/services/ are related to the one talking to the cloud, can we move this to somewhere else like pkg/utils and rename fix the naming aspect.

Dockerfile Address comments Comment Dockerfile Comment

mayuka-c · 2025-08-26T02:58:01Z

overall LGTM with a minor comment

I have moved the pagining utils under pkg/ dir. Thanks!

mkumatag

/lgtm

k8s-ci-robot · 2025-08-26T05:12:20Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mayuka-c, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [mkumatag]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. area/provider/ibmcloud Issues or PRs related to ibmcloud provider labels Aug 19, 2025

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 19, 2025

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 19, 2025

k8s-ci-robot requested review from mkumatag and Prajyot-Parab August 19, 2025 15:07

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 19, 2025

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 19, 2025

mayuka-c force-pushed the fix-issue-2458 branch from 419b5d8 to 7a47110 Compare August 20, 2025 01:41

Prajyot-Parab reviewed Aug 21, 2025

View reviewed changes

mayuka-c force-pushed the fix-issue-2458 branch from 7a47110 to 4da6308 Compare August 22, 2025 05:14

mkumatag requested changes Aug 22, 2025

View reviewed changes

mayuka-c force-pushed the fix-issue-2458 branch 2 times, most recently from 72f3153 to 8f5bee1 Compare August 25, 2025 07:29

mkumatag requested changes Aug 25, 2025

View reviewed changes

mayuka-c force-pushed the fix-issue-2458 branch from 8f5bee1 to 1aae795 Compare August 26, 2025 02:39

Fix revive package name conventions

e2aeb43

Dockerfile Address comments Comment Dockerfile Comment

mayuka-c force-pushed the fix-issue-2458 branch from 1aae795 to e2aeb43 Compare August 26, 2025 02:53

mkumatag approved these changes Aug 26, 2025

View reviewed changes

k8s-ci-robot assigned mkumatag Aug 26, 2025

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 26, 2025

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2025

k8s-ci-robot merged commit d843fa5 into kubernetes-sigs:main Aug 26, 2025
13 checks passed

mayuka-c deleted the fix-issue-2458 branch August 26, 2025 05:26

	Copyright 2023 The Kubernetes Authors.
	Copyright 2025 The Kubernetes Authors.

Fix revive package name conventions #2464

Fix revive package name conventions #2464

Conversation

mayuka-c commented Aug 19, 2025 • edited by Prajyot-Parab Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify bot commented Aug 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Uh oh!

k8s-ci-robot commented Aug 19, 2025

Uh oh!

k8s-ci-robot commented Aug 19, 2025

Uh oh!

kishen-v commented Aug 19, 2025

Uh oh!

Prajyot-Parab Aug 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mkumatag left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mayuka-c commented Aug 26, 2025

Uh oh!

mkumatag left a comment

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Aug 26, 2025

Uh oh!

Uh oh!

Uh oh!

mayuka-c commented Aug 19, 2025 •

edited by Prajyot-Parab

Loading

netlify bot commented Aug 19, 2025 •

edited

Loading

Prajyot-Parab Aug 21, 2025 •

edited

Loading