-
Notifications
You must be signed in to change notification settings - Fork 303
✨ feat: add capv serviceaccount #3640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @viveksyngh. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
- Use a serviceaccount dedicated for capv instead of using an default serviceaccount from the namespace in which it is deployed
495337d
to
62134ec
Compare
/ok-to-test |
cc @zhanggbj (to assess impacts on supervisor mode) |
@viveksyngh Please check if this fully addresses: #3440 |
Thanks for sharing the reported issue. I can confirm that changes covers everything described in the issue. |
/lgtm |
LGTM label has been added. Git tree hash: 035343c0fd426ef4f4bbe5c038a8f4ead71efe69
|
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #3440