🌱 Fixing broken links

[adilGhaffarDev]

What this PR does / why we need it:
Fixing broken links

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

/area documentation

[adilGhaffarDev]

The links in the error are working fine:

ERROR: 1 dead links found in CONTRIBUTING.md !
[✖] https://github.com/kubernetes-sigs/cluster-api/labels/lifecycle%2Factive → Status: 404

ERROR: 3 dead links found in docs/proposals/20200804-windows-support.md !
[✖] #signing-of-the-components → Status: 404
[✖] #known-prototypes-and-prior-work → Status: 404
[✖] #version-skew-strategy → Status: 404

Not sure why we are getting the error.

[mboersma]

/area documentation

[mboersma]

I can also access lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. no problem. Is the error because the link checker isn't logged in to GitHub? (And why would any of this have changed?)

Edit: Oh, interesting how GitHub renders that link as just the label. 👍🏻

[mboersma]

Maybe we could try replacing the link
https://github.com/kubernetes-sigs/cluster-api/labels/lifecycle%2Factive with
https://github.com/kubernetes-sigs/cluster-api/issues?q=is%3Aissue%20state%3Aopen%20label%3Alifecycle%2Factive

They seem to lead to the same place, but the first has "labels" as its REST endpoint, and the latter has "issues". Could be worth trying since the link immediately before this problematic one references "issues" in a very similar way and doesn't seem to be causing problems.

[elmiko]

weird, guess the link checker is having some issue trying to make the url nice?

[adilGhaffarDev]

All issues are fixed now please check.

[mboersma]

/lgtm

Thanks for fixing this!

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 7ec8a8e9d46e95e42c24759563821a8fcdb11600

[fabriziopandini]

Thanks for looking into this, really appreciated
lgtm from my side when @sbueringer comments are addressed

[sbueringer]

@adilGhaffarDev Do you have time to address the open findings?

[mboersma]

Adil is on vacation until July 13th. I'll open a PR to replace this one.

[sbueringer]

No rush from my side. We can also wait a bit

[adilGhaffarDev]

No rush from my side. We can also wait a bit

I am back, and I have addressed the comments. Please check. Sorry for the delay.

[mboersma]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 4ecc1eb0851c9affa4533f926c603294b52d78cc

[sbueringer]

Thank you very much!!

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment