🌱 update metrics configuration to v1beta2 #12642
Conversation
k8s-ci-robot
added
area/ci
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/L
chrischdi
added
the
tide/merge-method-squash
chrischdi
changed the title
|
/hold Want to verify locally |
k8s-ci-robot
added
the
do-not-merge/hold
chrischdi
changed the title
|
verified locally. /assign @sbueringer |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
| @@ -2,9 +2,9 @@ | |||
| apiVersion: rbac.authorization.k8s.io/v1 | |||
| kind: ClusterRole | |||
| metadata: | |||
| name: kube-state-metrics-custom-resource-capi | |||
| labels: | |||
| kube-state-metrics/aggregate-to-manager: "true" | |||
There was a problem hiding this comment.
This was intentional, right?
| - spec | ||
| - remediation | ||
| - triggerIf | ||
| - unhealthyRange |
There was a problem hiding this comment.
I think this should be unhealthyInRange (same for metric name)
| @@ -234,7 +230,13 @@ spec: | |||
| topology_class: | |||
There was a problem hiding this comment.
This does not match the PR description
What this PR does / why we need it:
Updates the metrics configuration to use the v1beta2 api version instead of v1beta1.
Small adjustments to metrics:
capi_clusterclass_spec_topology_classref_namespace)capi_clusterclass_spec_topology_classtocapi_clusterclass_spec_topology_classref_namemaxUnhealthy, addedremediation_triggerif_unhealthylessthanorequaltoandremediation_triggerif_unhealthyrangeAdjustments to dashboards:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Part of:
/area ci