feat: Change epp and conformance to use v1 type InferencePool #1118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @capri-xiyue. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
size/XXL
|
This PR is based on #1116 |
|
/assign @robscott |
capri-xiyue
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
|
Not ready to review until #1116 is merged |
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
/retest |
|
/approve Lets keep the hold until we finish the v0.5 rollout, but looks great otherwise! Thanks Xiyue! |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: capri-xiyue, kfswain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
removed
the
lgtm
|
/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/hold until #1116 get merged |
k8s-ci-robot
added
the
do-not-merge/hold
|
/lgtm |
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
added
size/L
|
Thanks @capri-xiyue! /lgtm |
k8s-ci-robot
added
the
lgtm
|
/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
This was referenced Jul 22, 2025
kfswain
pushed a commit
to kfswain/llm-instance-gateway
that referenced
this pull request
Jul 31, 2025
…etes-sigs#1118) * rename x-k8s to apix and add v1 InferencePool to api/v1 * changed epp and conformance test to support v1 * fixed duplicate import * changed docker file * updated docker file * fixed naming collision * added fake approved annotation * try to fix unit tests * fixed typo * added annotation * fixed annotation * fixed integration test * fixed e2e test * change manifests * added rbac * Update api/v1/inferencepool_types.go Co-authored-by: Rob Scott <[email protected]> * Apply suggestions from code review Co-authored-by: Rob Scott <[email protected]> * use v1 type in v1alpha2 * clean unused depdendency * fixed code generator error * revert back * merge bob's change * upadted code-gen * remove deep copy needs * use codegen * tried all alias * push local changes * changed inferencepoollist not to use v1.InferencePoolList * changed comments * fixed presubmit * change to v1 ip * revert to corev1 objectreference * revert back to corev1 objectreference * change crd * remove crd * manually add x-k8s.io inferencepool * revert crd * revert to workable version * Revert "added rbac" This reverts commit c01cbc8. * run generator * re-run generate * revert to workable * revert to workable version * fixed test * test * revert it back to originall workable version * change to use v1alpha2 back * resolve merge conflicts * fixed typo * fixed typo * fixed pipeline * fixed boilerplate Signed-off-by: Xiyue Yu <[email protected]> * changed unused code * fixed pipeline: * fixed missing dependecny update * updated missing dependency * fixed imports * fixed change * fixed format * merge to v1-inferencepool * fixed integration test * fixed import * change to install scheme * fixed import * change back to main image * fixed import issue * fixed format --------- Signed-off-by: Xiyue Yu <[email protected]> Co-authored-by: Rob Scott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change epp and conformance to use v1 type InferencePool