feat: generate crd with version annotation.

[zetxqx]

Add the CRD annotation for gateway-api-inferecence-extention CRD

The generator is mostly copied from https://github.com/kubernetes-sigs/gateway-api/blob/main/pkg/generator/main.go but removed the channel support. Since the version is needed for conformance tests. I removed the channel support to make this a minimum change.

[netlify]

✅ Deploy Preview for gateway-api-inference-extension ready!

Name	Link
🔨 Latest commit	6f7c774
🔍 Latest deploy log	https://app.netlify.com/projects/gateway-api-inference-extension/deploys/6879f919f700fa00084e6294
😎 Deploy Preview	https://deploy-preview-1134--gateway-api-inference-extension.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[k8s-ci-robot]

Hi @zetxqx. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[capri-xiyue]

I guess with this self-written code generator approach, you need to change the Makefile, based on my experience, currently all generated code relies on make manifests and make generate, when the pipeline runs tests, it will call these two make command to re-generate all the files. Probably you need to change hack/update-codegen.sh

[nirrozenbaum]

@zetxqx can you please explain the motivation behind this PR? why should we move from a the common code generation libraries which are widely used in the community to having our own code for generation?

[zetxqx]

@zetxqx can you please explain the motivation behind this PR? why should we move from a the common code generation libraries which are widely used in the community to having our own code for generation?

@nirrozenbaum I was following what we have in the gateway-api(https://github.com/kubernetes-sigs/gateway-api/blob/main/pkg/generator/main.go) Currently we only have one active version and do not have any channels so this PR does not have much benefits. However, if we have more channels and versions to maintain, the benefit is we can have a single place to "consts.go" in this PR to change the version related stuff.

CC: @robscott

[capri-xiyue]

@zetxqx can you please explain the motivation behind this PR? why should we move from a the common code generation libraries which are widely used in the community to having our own code for generation?

@nirrozenbaum I was following what we have in the gateway-api(https://github.com/kubernetes-sigs/gateway-api/blob/main/pkg/generator/main.go) Currently we only have one active version and do not have any channels so this PR does not have much benefits. However, if we have more channels and versions to maintain, the benefit is we can have a single place to "consts.go" in this PR to change the version related stuff.

CC: @robscott

If we want to keep the common code generation libraries which are widely used in the community, one approach I can think of is that keep the pkg/consts.go and let conformance test use it, make sure that the version in pkg.consts.go be the same with the version in kubebuilder annotation comment.

[robscott]

Thanks @zetxqx!

[robscott]

After this they'll also have to manually regenerate the CRDs.

[zetxqx]

updated! @robscott could you please take a look? I mostly copy pasted from the gateway api here.

[robscott]

Thanks @zetxqx!

[robscott]

@kfswain @nirrozenbaum Do you need anything beyond CRDs that could have been generated here? (I'm assuming not, certainly not a webhook, and probably not RBAC, but just want to make sure I'm not missing some EPP dependencies here).

[nirrozenbaum]

nothing that I'm aware of.
sorry for the delayed response, missed the question.

[zetxqx]

/hold

hold to coordinate with #1156 not affecting the review

cc: @capri-xiyue

[capri-xiyue]

/hold

hold to coordinate with #1156 not affecting the review

cc: @capri-xiyue

@zetxqx #1156 got merged. Seems like you need to merge with the main branch and then run make generateto generate the CRD again.

[nirrozenbaum]

/lgtm