-
Notifications
You must be signed in to change notification settings - Fork 138
chore: update vllm deployment tag to latest #1184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
/retest |
@@ -14,7 +14,7 @@ spec: | |||
spec: | |||
containers: | |||
- name: lora | |||
image: "public.ecr.aws/q9t5s3a7/vllm-cpu-release-repo:v0.9.1" # formal images can be found in https://gallery.ecr.aws/q9t5s3a7/vllm-cpu-release-repo | |||
image: "public.ecr.aws/q9t5s3a7/vllm-cpu-release-repo:latest" # formal images can be found in https://gallery.ecr.aws/q9t5s3a7/vllm-cpu-release-repo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this one is great
@@ -14,7 +14,7 @@ spec: | |||
spec: | |||
containers: | |||
- name: vllm-sim | |||
image: ghcr.io/llm-d/llm-d-inference-sim:v0.1.2 | |||
image: ghcr.io/llm-d/llm-d-inference-sim:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this one is a bit more problematic. there is another open PR that was trying to do the same.
see my comment there if your'e interesting in more details:
#1140
I think we can keep this PR focused on the cpu example update to get it merged quickly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep updated
Signed-off-by: bitliu <[email protected]>
8a1df2a
to
54b5abf
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nirrozenbaum, Xunzhuo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes: #1022