-
Notifications
You must be signed in to change notification settings - Fork 154
Adding Kubvernor to the list of implementors #1313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Adding Kubvernor to the list of implementors #1313
Conversation
Signed-off-by: Dawid Nowak <[email protected]>
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Hi @dawid-nowak. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
ping @robscott |
Thanks @dawid-nowak! /lgtm |
Signed-off-by: Dawid Nowak <[email protected]>
New changes are detected. LGTM label has been removed. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dawid-nowak The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Dawid Nowak <[email protected]>
Co-authored-by: Nir Rozenbaum <[email protected]>
pretty please, could we move it forward... |
This PR follows what we have been doing up to this point as a project (implementation-specific guides), but per #1502 we likely need to start moving away from that. Given that we already have this level of content for many other implementations, it could be viable to accept this as is and then immediately work to retract implementation-specific content more broadly. |
@liu-cong @nirrozenbaum @danehans Don't leave me hanging 😃 |
+1 on this. Deferring to @danehans and @nirrozenbaum to make the call |
site-src/guides/index.md
Outdated
[Kubvernor Rust API Gateway](https://github.com/kubvernor/kubvernor) is a higly experimental project so not ready for production but it supports version v0.5.1 of Inference Extension Spec. | ||
|
||
1. Requirements | ||
- Rust and Cargo installed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A user should not be required to install Rust to deploy a GIE gateway. Common deployment tools such as kubectl, Helm, etc., should be the only requirement for a user to deploy.
site-src/guides/index.md
Outdated
1. Requirements | ||
- Rust and Cargo installed | ||
|
||
2. Run Kubvernor Rust API Gateway as documented in [README](https://github.com/kubvernor/kubvernor/blob/main/README.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All required steps should be captured here instead of an external link
Note: Due to #1502, we plan on removing most 3rd party content from the docs site. We will instead refer to the implementations page. Conformant implementations will be required to maintain their own install guides.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I followed the referenced readme but the ./run_kubvernor.sh
step failed:
$ rustc --version
rustc 1.89.0 (29483883e 2025-08-04)
$ cargo version
cargo 1.89.0 (c24e10642 2025-06-23)
$ echo $CONTROL_PLANE_IP
172.18.0.2
$ ./run_kubvernor.sh
...
--- stderr
Error: Custom { kind: Other, error: "protoc failed: google/protobuf/timestamp.proto: File not found.\ngoogle/protobuf/descriptor.proto: File not found.\nudpa/annotations/status.proto: Import \"google/protobuf/descriptor.proto\" was not found or had errors.\nudpa/annotations/status.proto:15:8: \"google.protobuf.FileOptions\" is not defined.\nudpa/annotations/versioning.proto: Import \"google/protobuf/descriptor.proto\" was not found or had errors.\nudpa/annotations/versioning.proto:13:8: \"google.protobuf.MessageOptions\" is not defined.\nenvoy/admin/v3/certs.proto: Import \"google/protobuf/timestamp.proto\" was not found or had errors.\nenvoy/admin/v3/certs.proto: Import \"udpa/annotations/status.proto\" was not found or had errors.\nenvoy/admin/v3/certs.proto: Import \"udpa/annotations/versioning.proto\" was not found or had errors.\nenvoy/admin/v3/certs.proto:45:5: \"google.protobuf.Timestamp\" is not defined.\nenvoy/admin/v3/certs.proto:48:5: \"google.protobuf.Timestamp\" is not defined.\nenvoy/admin/v3/certs.proto:64:3: \"google.protobuf.Timestamp\" is not defined.\nenvoy/admin/v3/certs.proto:67:3: \"google.protobuf.Timestamp\" is not defined.\n" }
warning: build failed, waiting for other jobs to finish...
This is a good example of why https://github.com/kubernetes-sigs/gateway-api-inference-extension/pull/1313/files#r2316592252.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All required steps should be captured here instead of an external link
Note: Due to #1502, we plan on removing most 3rd party content from the docs site. We will instead refer to the implementations page. Conformant implementations will be required to maintain their own install guides.
Yeah, but that would potentially make this page even more unreadable. And even for GKE there is a link to external docs. Perhaps it is ok to proceed as is. Given that this is going to change anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I followed the referenced readme but the
./run_kubvernor.sh
step failed:$ rustc --version rustc 1.89.0 (29483883e 2025-08-04) $ cargo version cargo 1.89.0 (c24e10642 2025-06-23) $ echo $CONTROL_PLANE_IP 172.18.0.2 $ ./run_kubvernor.sh ... --- stderr Error: Custom { kind: Other, error: "protoc failed: google/protobuf/timestamp.proto: File not found.\ngoogle/protobuf/descriptor.proto: File not found.\nudpa/annotations/status.proto: Import \"google/protobuf/descriptor.proto\" was not found or had errors.\nudpa/annotations/status.proto:15:8: \"google.protobuf.FileOptions\" is not defined.\nudpa/annotations/versioning.proto: Import \"google/protobuf/descriptor.proto\" was not found or had errors.\nudpa/annotations/versioning.proto:13:8: \"google.protobuf.MessageOptions\" is not defined.\nenvoy/admin/v3/certs.proto: Import \"google/protobuf/timestamp.proto\" was not found or had errors.\nenvoy/admin/v3/certs.proto: Import \"udpa/annotations/status.proto\" was not found or had errors.\nenvoy/admin/v3/certs.proto: Import \"udpa/annotations/versioning.proto\" was not found or had errors.\nenvoy/admin/v3/certs.proto:45:5: \"google.protobuf.Timestamp\" is not defined.\nenvoy/admin/v3/certs.proto:48:5: \"google.protobuf.Timestamp\" is not defined.\nenvoy/admin/v3/certs.proto:64:3: \"google.protobuf.Timestamp\" is not defined.\nenvoy/admin/v3/certs.proto:67:3: \"google.protobuf.Timestamp\" is not defined.\n" } warning: build failed, waiting for other jobs to finish...
This is a good example of why https://github.com/kubernetes-sigs/gateway-api-inference-extension/pull/1313/files#r2316592252.
Thanks, I have updated Kubvernor README.
@dawid-nowak thanks for your patience with this PR while we've been focused on the v1.0 release candidate. Please take a look at my review feedback. |
…plementor_v2' into adding_kubvernor_implementor_v2
Signed-off-by: Dawid Nowak <[email protected]>
@danehans Thanks again for the review.. I hope I have addressed your concerns. |
/retest |
/retest-required |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dawid-nowak! LGTM except for the extra file.
Signed-off-by: Dawid Nowak <[email protected]>
Kubvernor Rust API Gateway is an open-source, highly experimental implementation of API controller in Rust programming language. Currently, Kubernor supports Envoy Proxy. The project aims to be as generic as possible so Kubvernor can be used to manage/deploy different gateways (Envoy, Nginx, HAProxy, etc.). Kubvernor Rust API Gateway implements Inference Extensions v0.5.1.