cleanup: simplify endpointpickerconfig #1324

capri-xiyue · 2025-08-07T17:43:29Z

simplify endpointpickerconfig

netlify · 2025-08-07T17:43:35Z

✅ Deploy Preview for gateway-api-inference-extension ready!

Name	Link
🔨 Latest commit	`d4cd681`
🔍 Latest deploy log	https://app.netlify.com/projects/gateway-api-inference-extension/deploys/689a70044620fd000837c6f6
😎 Deploy Preview	https://deploy-preview-1324--gateway-api-inference-extension.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

k8s-ci-robot · 2025-08-07T17:43:39Z

Hi @capri-xiyue. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

config/crd/bases/inference.networking.k8s.io_inferencepools.yaml

capri-xiyue · 2025-08-07T18:08:49Z

If we remove inline, I think we have to change the underlying crd. Another option is to remove the endpointerpick struct directly, see the updated PR #1324. However, Abdullah Gharaibeh mentioned If we are removing this struct, we may want to rename extensionRef to make it explicit that this is an epp extension?(see #1173 (comment)) With renaming, the crd will also change.

To avoid break change to the crd, should we just skip the renaming? cc @robscott @ahg-g

liu-cong · 2025-08-07T18:35:08Z

/ok-to-test

ahg-g · 2025-08-11T12:31:49Z

/assign @robscott

robscott · 2025-08-11T21:49:47Z

Thanks @capri-xiyue!

/lgtm

capri-xiyue · 2025-08-11T22:13:21Z

/assign @kfswain

capri-xiyue · 2025-08-11T22:55:35Z

/assign @nirrozenbaum

ahg-g · 2025-08-12T16:56:15Z

/approve

k8s-ci-robot · 2025-08-12T16:56:23Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, capri-xiyue

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [ahg-g]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ahg-g · 2025-08-12T16:56:37Z

/lgtm

nirrozenbaum

@capri-xiyue reviewed the PR.
Abdullah beat me with lgtm :)

the PR looks good to me, I left nit comments on places I think the rename from Extension to ExtensionRef should be reverted. mostly in comments/log messages. nbd.

nirrozenbaum · 2025-08-12T17:47:42Z

conformance/conformance.go

-// for the Gateway API Inference Extension conformance test suite.
+// for the Gateway API Inference ExtensionRef conformance test suite.


nit: revert

nirrozenbaum · 2025-08-12T17:48:08Z

conformance/conformance.go

-// the Gateway API layer aspects of the Inference Extension (e.g., InferencePool, InferenceObjective CRDs).
+// the Gateway API layer aspects of the Inference ExtensionRef (e.g., InferencePool, InferenceObjective CRDs).


nirrozenbaum · 2025-08-12T17:48:40Z

conformance/conformance.go

-// of the "Gateway" profile for the Inference Extension MUST support.
+// of the "Gateway" profile for the Inference ExtensionRef MUST support.


nirrozenbaum · 2025-08-12T17:48:54Z

conformance/conformance.go

-	// Inference Extension Specific Report Fields
+	// Inference ExtensionRef Specific Report Fields


nirrozenbaum · 2025-08-12T17:48:59Z

conformance/conformance.go

-	// Register Inference Extension API types
+	// Register Inference ExtensionRef API types


nirrozenbaum · 2025-08-12T17:50:56Z

conformance/utils/assertions.go

-// TODO: Implement custom assertion functions specific to Inference Extension testing.
+// TODO: Implement custom assertion functions specific to Inference ExtensionRef testing.


nirrozenbaum · 2025-08-12T17:51:16Z

pkg/epp/metrics/metrics.go

-			Help:      metricsutil.HelpMsgWithStability("General information of the current build of Inference Extension.", compbasemetrics.ALPHA),
+			Help:      metricsutil.HelpMsgWithStability("General information of the current build of Inference ExtensionRef.", compbasemetrics.ALPHA),


nirrozenbaum · 2025-08-12T17:51:24Z

pkg/epp/flowcontrol/controller/doc.go

-// Inference Extension's Endpoint Picker (EPP), which operates as an Envoy External Processing (`ext_proc`) server, this
+// Inference ExtensionRef's Endpoint Picker (EPP), which operates as an Envoy External Processing (`ext_proc`) server, this


nirrozenbaum · 2025-08-12T17:52:00Z

test/e2e/epp/e2e_suite_test.go

-// createCRDs creates the Inference Extension CRDs used for testing.
+// createCRDs creates the Inference ExtensionRef CRDs used for testing.


nirrozenbaum · 2025-08-12T17:52:08Z

test/e2e/epp/e2e_test.go

-	ginkgo.When("The Inference Extension is running", func() {
+	ginkgo.When("The Inference ExtensionRef is running", func() {


remove inline of endpointconfig

79b06b2

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 7, 2025

k8s-ci-robot requested review from ahg-g and danehans August 7, 2025 17:43

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 7, 2025

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 7, 2025

capri-xiyue commented Aug 7, 2025

View reviewed changes

config/crd/bases/inference.networking.k8s.io_inferencepools.yaml Outdated Show resolved Hide resolved

simplify extension ref

e5e2ff3

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 7, 2025

capri-xiyue changed the title ~~cleanup: remove inline of endpointpickerconfig~~ cleanup: simplify endpointpickerconfig Aug 7, 2025

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 7, 2025

capri-xiyue mentioned this pull request Aug 7, 2025

v1.0 InferencePool API Review #1173

Open

k8s-ci-robot assigned robscott Aug 11, 2025

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 11, 2025

remove inline

6cb769c

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 11, 2025

capri-xiyue added 2 commits August 11, 2025 15:04

remove inline

91ef31a

fixed ut

13900f9

k8s-ci-robot assigned kfswain Aug 11, 2025

fixed verify

d4cd681

k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 11, 2025

k8s-ci-robot assigned nirrozenbaum Aug 11, 2025

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2025

k8s-ci-robot assigned ahg-g Aug 12, 2025

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 12, 2025

k8s-ci-robot merged commit 131eddc into kubernetes-sigs:main Aug 12, 2025
9 checks passed

nirrozenbaum mentioned this pull request Aug 12, 2025

Upgrade the inferencePool selector to a struct from a map. #1330

Merged

danehans mentioned this pull request Aug 12, 2025

InferencePool: Finalize ExtensionRef Type #1364

Closed

nirrozenbaum reviewed Aug 12, 2025

View reviewed changes

capri-xiyue mentioned this pull request Aug 12, 2025

fix: make extensionRef to be optional #1365

Merged

		// for the Gateway API Inference Extension conformance test suite.
		// for the Gateway API Inference ExtensionRef conformance test suite.

		// the Gateway API layer aspects of the Inference Extension (e.g., InferencePool, InferenceObjective CRDs).
		// the Gateway API layer aspects of the Inference ExtensionRef (e.g., InferencePool, InferenceObjective CRDs).

		// of the "Gateway" profile for the Inference Extension MUST support.
		// of the "Gateway" profile for the Inference ExtensionRef MUST support.

		// Inference Extension Specific Report Fields
		// Inference ExtensionRef Specific Report Fields

		// Register Inference Extension API types
		// Register Inference ExtensionRef API types

		// TODO: Implement custom assertion functions specific to Inference Extension testing.
		// TODO: Implement custom assertion functions specific to Inference ExtensionRef testing.

		Help: metricsutil.HelpMsgWithStability("General information of the current build of Inference Extension.", compbasemetrics.ALPHA),
		Help: metricsutil.HelpMsgWithStability("General information of the current build of Inference ExtensionRef.", compbasemetrics.ALPHA),

		// Inference Extension's Endpoint Picker (EPP), which operates as an Envoy External Processing (`ext_proc`) server, this
		// Inference ExtensionRef's Endpoint Picker (EPP), which operates as an Envoy External Processing (`ext_proc`) server, this

		// createCRDs creates the Inference Extension CRDs used for testing.
		// createCRDs creates the Inference ExtensionRef CRDs used for testing.

		ginkgo.When("The Inference Extension is running", func() {
		ginkgo.When("The Inference ExtensionRef is running", func() {

cleanup: simplify endpointpickerconfig #1324

cleanup: simplify endpointpickerconfig #1324

Uh oh!

Conversation

capri-xiyue commented Aug 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify bot commented Aug 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for gateway-api-inference-extension ready!

Uh oh!

k8s-ci-robot commented Aug 7, 2025

Uh oh!

Uh oh!

capri-xiyue commented Aug 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

liu-cong commented Aug 7, 2025

Uh oh!

ahg-g commented Aug 11, 2025

Uh oh!

robscott commented Aug 11, 2025

Uh oh!

capri-xiyue commented Aug 11, 2025

Uh oh!

capri-xiyue commented Aug 11, 2025

Uh oh!

ahg-g commented Aug 12, 2025

Uh oh!

k8s-ci-robot commented Aug 12, 2025

Uh oh!

ahg-g commented Aug 12, 2025

Uh oh!

Uh oh!

nirrozenbaum left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

capri-xiyue commented Aug 7, 2025 •

edited

Loading

netlify bot commented Aug 7, 2025 •

edited

Loading

capri-xiyue commented Aug 7, 2025 •

edited

Loading