Skip to content

minor updates and godoc to weighted random picker #1514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 4, 2025
Merged

minor updates and godoc to weighted random picker #1514

merged 1 commit into from
Sep 4, 2025

Conversation

nirrozenbaum
Copy link
Contributor

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
minor updates and godoc to picker
Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Sep 1, 2025
@netlify Netlify
Copy link

netlify bot commented Sep 1, 2025 •
edited
Loading

✅ Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit a8d9f4a
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/68b9251a5561910008a51f23
😎 Deploy Preview https://deploy-preview-1514--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 1, 2025
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2025
@nirrozenbaum
Copy link
Contributor Author

cc @Jooho

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 1, 2025
Jooho
Jooho approved these changes Sep 2, 2025
View reviewed changes
Copy link
Contributor

@Jooho Jooho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

@Jooho: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jooho, nirrozenbaum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nirrozenbaum nirrozenbaum changed the title minor updates and godoc to picker minor updates and godoc to weighted random picker Sep 4, 2025
@kfswain
Copy link
Collaborator

kfswain commented Sep 4, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 4, 2025
@k8s-ci-robot
Copy link
Contributor

@nirrozenbaum: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gateway-api-inference-extension-test-unit-main a8d9f4a link unknown /test pull-gateway-api-inference-extension-test-unit-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@nirrozenbaum
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit c7c7b8a into kubernetes-sigs:main Sep 4, 2025
10 of 11 checks passed
@nirrozenbaum nirrozenbaum deleted the picker branch September 4, 2025 17:00
@nirrozenbaum nirrozenbaum mentioned this pull request Sep 5, 2025
Open
nirrozenbaum added a commit that referenced this pull request Sep 5, 2025
@nirrozenbaum
minor updates and godoc to weighted random picker (#1514)
13041fe 
Signed-off-by: Nir Rozenbaum <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfswain kfswain Awaiting requested review from kfswain

@robscott robscott Awaiting requested review from robscott

1 more reviewer

@Jooho Jooho Jooho approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@kfswain kfswain

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nirrozenbaum @k8s-ci-robot @kfswain @Jooho