-
Notifications
You must be signed in to change notification settings - Fork 480
frontend: Handle CRDs with identical plural names #3778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
frontend: Handle CRDs with identical plural names #3778
Conversation
|
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pablogarciamiranda The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Welcome @pablogarciamiranda! |
1df3b6c to
37ba09d
Compare
skoeva
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like there's also a few tests in the CI failing, would be good to address those
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |

Summary
This PR fixes the routing conflict that occurs when multiple Custom Resource Definitions (CRDs) have the same plural name but belong to different API groups.
Related Issue
Fixes #3778
Changes
groupparameter to CRD routes{plural}.{group}format for CRD identificationSteps to Test
Screenshots (if applicable)
Notes for the Reviewer