Skip to content

Conversation

@pablogarciamiranda
Copy link

@pablogarciamiranda pablogarciamiranda commented Aug 12, 2025

Summary

This PR fixes the routing conflict that occurs when multiple Custom Resource Definitions (CRDs) have the same plural name but belong to different API groups.

Related Issue

Fixes #3778

Changes

  • Added group parameter to CRD routes
  • Updated components to use {plural}.{group} format for CRD identification
  • Modified CRD list to show API group in parentheses
  • Fixed navigation links to include both group and plural name

Steps to Test

  1. Create two CRDs with the same plural name but different groups
  2. Navigate to the CRDs list
  3. Click on each CRD and verify correct resources are shown
  4. Check that navigation between CRDs works properly

Screenshots (if applicable)

Notes for the Reviewer

  • Backwards compatible with existing CRDs
  • Group now visible in CRD list for better identification

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 12, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: pablogarciamiranda / name: Pablo García Miranda (37ba09d)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Aug 12, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pablogarciamiranda
Once this PR has been reviewed and has the lgtm label, please assign illume for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Welcome @pablogarciamiranda!

It looks like this is your first PR to kubernetes-sigs/headlamp 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/headlamp has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 12, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 12, 2025
@pablogarciamiranda pablogarciamiranda changed the title fix: Handle CRDs with identical plural names frontend: Handle CRDs with identical plural names Aug 13, 2025
@sniok
Copy link
Contributor

sniok commented Aug 13, 2025

Correct me if I'm wrong but the group is already included in the CRD name, so I'm not sure if this change is needed.

image

Could you share a more detailed way to reproduce a problem you're experiencing? The issue number you included in the description just points to this PR

Copy link
Contributor

@skoeva skoeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like there's also a few tests in the CI failing, would be good to address those

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 4, 2025
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@skoeva skoeva closed this Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants