Feature: now sidebar can have external urls #3889
Merged
+24
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
skoeva
reviewed
Sep 9, 2025
k8s-ci-robot
added
size/L
Exar04
force-pushed
the
feat-sidebar-external-link
branch
from
2c66bd4 to
5c02b40
Compare
k8s-ci-robot
added
size/M
…nd forward us to external page
Exar04
force-pushed
the
feat-sidebar-external-link
branch
from
5c02b40 to
ca33ad1
Compare
illume
added
kind/feature
joaquimrocha
approved these changes
Sep 24, 2025
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Exar04, joaquimrocha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #2128
This does fixes the issue but not sure if we should do it this way
In this pr we it is checking if url starts with
httpand if it does then that means our url is external and should open up in new tab.example -
url: "https://www.youtube.com"will open up in different windowbut
url: "/someComponent"will route within the headlampalso as said in issue, we could add a separate
external_urlfield to explicitly handle external URLs, but this may lead to ambiguity if bothurlandexternal_urlare set by mistake