-
Notifications
You must be signed in to change notification settings - Fork 443
frontend: fix the ChipToggleButton doesn't display Chinese text completely #3903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch! be sure to update the snapshots in the frontend using make frontend-test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! could you squash the commits? looks good otherwise
b8a8125
to
a2e9f72
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joaquimrocha, skoeva, wingerx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary
This PR fixes the ChipToggleButton display issue in GraphView component where Chinese text was being truncated by increasing the line height.
Changes
Steps to Test
Screenshots (if applicable)
Before: Chinese text was truncated in ChipToggleButton


After: Chinese text displays completely with proper spacing


Notes for the Reviewer