Skip to content

headlamp-plugin: Export missing functions #3906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2025
Merged

headlamp-plugin: Export missing functions #3906

merged 1 commit into from
Sep 17, 2025

Conversation

@illume
Copy link
Contributor

@illume illume commented Sep 13, 2025

So that plugin type checkers are happy.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 13, 2025
@illume illume added kind/bug Categorizes issue or PR as related to a bug. plugins headlamp-plugin Related to the headlamp-plugin NPM package. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 13, 2025
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 13, 2025
@illume
headlamp-plugin: Export missing functions
f624b6a 
So that plugin type checkers are happy.
skoeva
skoeva approved these changes Sep 16, 2025
View reviewed changes
Copy link
Contributor

@skoeva skoeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: illume, skoeva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@joaquimrocha
Copy link
Contributor

/lgtm
/approved

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 17, 2025
@k8s-ci-robot k8s-ci-robot merged commit 40f6255 into kubernetes-sigs:main Sep 17, 2025
12 checks passed
@illume illume added this to the v0.36.0 milestone Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skoeva skoeva skoeva approved these changes

@vyncent-t vyncent-t Awaiting requested review from vyncent-t

@yolossn yolossn Awaiting requested review from yolossn

Assignees

@joaquimrocha joaquimrocha

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. headlamp-plugin Related to the headlamp-plugin NPM package. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. plugins size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

v0.36.0

Development

Successfully merging this pull request may close these issues.

4 participants

@illume @k8s-ci-robot @joaquimrocha @skoeva