-
Notifications
You must be signed in to change notification settings - Fork 454
frontend: Fix bundled icons and the test #3920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes the bundled icons test and updates icon definitions to ensure all icons are properly cached for offline use. It refactors the test to use a base directory parameter and updates the icon data with improved SVG paths and new icon definitions.
- Fix the icons test by adding a baseDir parameter to the file filter function
- Update all existing icon SVG paths with HTML entity encodings
- Add new icon definitions and aliases to support additional UI elements
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| frontend/src/filesFilter/filesFilter.ts | Add optional baseDir parameter to support custom base directories for file filtering |
| frontend/src/components/App/icons.ts | Update icon SVG paths with HTML entities and add numerous new icon definitions and aliases |
| frontend/src/components/App/icons.test.ts | Refactor test to use baseDir parameter and improve error reporting for missing icons |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs tests.
what do you mean? this PR fixes the test that was broken |
|
Code looks fine. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joaquimrocha, sniok The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR fixes the icons test that checks that all icons are bundled properly
And updates all the latest icons to be included in the bundle
Related Issue
Fixes #3919 #3886
Steps to Test