Skip to content

WIP 🌱 fix: E2E test for conversion webhook #4475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+19 −1
Open

WIP 🌱 fix: E2E test for conversion webhook #4475

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ test-e2e-local: ## Run the end-to-end tests locally
./test/e2e/local.sh

.PHONY: test-e2e-ci
test-e2e-ci: ## Run the end-to-end tests (used in the CI)`
test-e2e-ci: ## Run the end-to-end tests (used in the CI)
./test/e2e/ci.sh

.PHONY: test-book
Expand Down
18 changes: 18 additions & 0 deletions docs/book/src/multiversion-tutorial/testdata/project/test/e2e/e2e_test.go
View file
Open in desktop
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@camilamacedo86 can you check if this change is enough?

after validation, I will apply changes to https://github.com/kubernetes-sigs/kubebuilder/blob/master/hack/docs/internal/multiversion-tutorial/generate_multiversion.go file

Original file line number Diff line number Diff line change
Expand Up @@ -313,6 +313,24 @@ var _ = Describe("Manager", Ordered, func() {
Eventually(verifyCAInjection).Should(Succeed())
})

It("should convert CronJob v1 to v2", func() {
By("creating CronJob v1 resource")
cmd := exec.Command(
"kubectl", "create",
"-f", filepath.Join("config", "samples", "batch_v1_cronjob.yaml"),
)
_, err := utils.Run(cmd)
Expect(err).NotTo(HaveOccurred(), "Failed to create CronJob v1 resource")

By("fetching CronJob v2 resource")
cmd = exec.Command(
"kubectl", "get",
"cronjobs.v2.batch.tutorial.kubebuilder.io", "cronjob-sample",
)
_, err = utils.Run(cmd)
Expect(err).NotTo(HaveOccurred(), "Failed to get CronJob v2 resource")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we validate some spec that we are converting?

})

// +kubebuilder:scaffold:e2e-webhooks-checks

// TODO: Customize the e2e test suite with scenarios specific to your project.
Expand Down