⚠ (helm/v1-alpha): remove init command from Helm plugin as it's only meaningful with edit

[bavarianbidi]

The helm-plugin is meant to extend an existing go project. For a correct rendering of the helm-chart some information (like the project name) from the go project is needed.

closes #4902

[k8s-ci-robot]

Hi @bavarianbidi. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[camilamacedo86]

/ok-to-test

[camilamacedo86]

/overwrite APIDiff

[camilamacedo86]

@bavarianbidi we can overwrite the APIDiff that is fine no worry
But we need to pass in the other tests
The link you can check locally with make lint and make lint-fix

Thank you a lot for looking on that 🎉

[camilamacedo86]

Could we have a PR only for the e2e tests?
Ideally we should have one PR for each purpose
AND
with only one commit

Could you please do that for we are able to move forward?

[bavarianbidi]

regarding a separate PR for e2e-tests:
let us please came up with an idea on #4903 (comment) and #4903 (comment) first 🙏

regarding squashing: let's decided on ☝️ and than I can squash all the commits which belong to this PR.

[camilamacedo86]

If we have a PR to remove the init then we can get it merged asap
If we have a PR with tests added, we just need to discuss what we are testing and how, then we can also get it merged asap, once we reach a consensus

The request here is simply for us to split so that we have a PR for each purpose, allowing us to provide better Git history and release notes.

Regarding the commit squash, yes, we have this golden rule: if we can, it would be amazing!

[bavarianbidi]

just raised PR #4914 for testing the existing behavior of kubebuilder edit --plugins helm.kubebuilder.io/v1-alpha

[bavarianbidi]

rebased and pushed again - PTAL 🙏

[camilamacedo86]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bavarianbidi, camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [camilamacedo86]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment