🌱: introduce gci as formatter in golangci-lint

[bavarianbidi]

To have a common appearance of the import section, gci as formatter is enforcing the following pattern of imports:

    gci:
      sections:
        - standard
        - default
        - prefix(sigs.k8s.io/kubebuilder)
        - dot

xref: gci documentation - https://golangci-lint.run/usage/formatters/#gci

This is a follow-up task by a PR comment in #4914

[k8s-ci-robot]

Hi @bavarianbidi. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[mateusoliveira43]

should we also add to scaffolded config?

[bavarianbidi]

should we also add to scaffolded config?

I like the idea, but as we already use different formatter/linter-config, I wasn't sure about when to extend the skaffolding files:

formatters in the project scaffolding (xref: skaffolding golangci.yaml)

formatters:
  enable:
    - gofmt
    - goimports

formatters in the kubebuilder golangci.yaml config xref: kubebuilder golangci yaml

formatters:
  enable:
    - gci
    - gofmt
    - gofumpt
    - goimports

[camilamacedo86]

I like the idea, but as we already use different formatter/linter-config, I wasn't sure about when to extend the skaffolding files:

It's a good idea to see if there are things we can improve upon.
I would love get your help with
But we need one PR for each new one added there since we will need to change the scaffold

[camilamacedo86]

/lgtm

Thank you 🥇

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bavarianbidi, camilamacedo86, mateusoliveira43

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [camilamacedo86]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[camilamacedo86]

/ok-to-test
/lgtm