Skip to content

Conversation

@pratik-mahalle
Copy link

Summary

Upgrades the Go toolchain from 1.22.7 to 1.24.4 across the entire repository to address CVE-2025-22871 (Critical severity).

Changes

  • Toolchain: Added toolchain go1.24.4 directive in go.work
  • CI/CD: Updated GitHub Actions workflows to use Go 1.24.4
  • Docker Images: Upgraded all Dockerfiles from golang:1.22.7-bullseye to golang:1.24.4-bullseye
  • Site Build: Updated site/Dockerfile from golang:1.24-alpine to golang:1.24.4-alpine
  • Embedded Templates: Updated Go version references in:
    • Framework command generators (kyaml/fn/framework/command/)
    • Plugin converter templates (cmd/pluginator/)
    • Documentation examples (cmd/config/docs/)
  • Linter: Updated .golangci.yml to target Go 1.24

Security Impact

  • Resolves CVE-2025-22871 (Critical) - vulnerability present in Go versions < 1.24.4
  • Ensures all builds (local, CI, and containerized) use the secure Go version
  • Maintains backward compatibility with existing Go 1.22.7 language features

Testing

  • All unit tests pass with the new toolchain
  • No breaking changes to existing functionality
  • Verified toolchain enforcement works correctly

Files Modified

  • go.work - Added toolchain directive
  • .github/workflows/*.yml - Updated CI Go versions
  • **/Dockerfile* - Updated base image tags
  • kyaml/fn/framework/command/command.go - Updated embedded Dockerfile template
  • cmd/pluginator/internal/krmfunction/converter.go - Updated Dockerfile string
  • Documentation and test files with embedded version references

/kind security
/priority critical

@k8s-ci-robot
Copy link
Contributor

This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

@pratik-mahalle: The label(s) kind/security, priority/critical cannot be applied, because the repository doesn't have them.

In response to this:

Summary

Upgrades the Go toolchain from 1.22.7 to 1.24.4 across the entire repository to address CVE-2025-22871 (Critical severity).

Changes

  • Toolchain: Added toolchain go1.24.4 directive in go.work
  • CI/CD: Updated GitHub Actions workflows to use Go 1.24.4
  • Docker Images: Upgraded all Dockerfiles from golang:1.22.7-bullseye to golang:1.24.4-bullseye
  • Site Build: Updated site/Dockerfile from golang:1.24-alpine to golang:1.24.4-alpine
  • Embedded Templates: Updated Go version references in:
  • Framework command generators (kyaml/fn/framework/command/)
  • Plugin converter templates (cmd/pluginator/)
  • Documentation examples (cmd/config/docs/)
  • Linter: Updated .golangci.yml to target Go 1.24

Security Impact

  • Resolves CVE-2025-22871 (Critical) - vulnerability present in Go versions < 1.24.4
  • Ensures all builds (local, CI, and containerized) use the secure Go version
  • Maintains backward compatibility with existing Go 1.22.7 language features

Testing

  • All unit tests pass with the new toolchain
  • No breaking changes to existing functionality
  • Verified toolchain enforcement works correctly

Files Modified

  • go.work - Added toolchain directive
  • .github/workflows/*.yml - Updated CI Go versions
  • **/Dockerfile* - Updated base image tags
  • kyaml/fn/framework/command/command.go - Updated embedded Dockerfile template
  • cmd/pluginator/internal/krmfunction/converter.go - Updated Dockerfile string
  • Documentation and test files with embedded version references

/kind security
/priority critical

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 15, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pratik-mahalle
Once this PR has been reviewed and has the lgtm label, please assign koba1t for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Welcome @pratik-mahalle!

It looks like this is your first PR to kubernetes-sigs/kustomize 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kustomize has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @pratik-mahalle. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 15, 2025
@koba1t
Copy link
Member

koba1t commented Aug 16, 2025

Hi @pratik-mahalle
Thanks for report and try to fix security issue.

But, I think we don't use net/http server in this project.
Where did you find it being used?

@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 17, 2025
@koba1t
Copy link
Member

koba1t commented Sep 29, 2025

I think that problem was fixed by #5959

/close

@k8s-ci-robot
Copy link
Contributor

@koba1t: Closed this PR.

In response to this:

I think that problem was fixed by #5959

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants