fix(api): configmaps items generated in order

[manute]

Hey,

Just created this PR to see if it can be resolved this issue #4292

Any feedback appreciate, thanks!

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: manute / name: Manuel Alonso (2ad7965, 30a91e3, 75e9e35, dcb55de)

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: manute
Once this PR has been reviewed and has the lgtm label, please assign varshaprasad96 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Welcome @manute!

It looks like this is your first PR to kubernetes-sigs/kustomize 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kustomize has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @manute. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[koba1t]

If you claim to have fixed something, please include sufficient test cases before opening a pull request.

[k8s-ci-robot]

This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[manute]

If you claim to have fixed something, please include sufficient test cases before opening a pull request.

Added tests, thanks

[jpfourny]

Won't passing the raw map here throw away the sorting effort?
Also, it looks like sorting is done in LoadMapIntoConfigMapData already:

kustomize/kyaml/yaml/datamap.go

Line 27 in 17a06a7

for _, k := range SortedMapKeys(m) {

I am starting to wonder if the problem happens somewhere else. Could the resource be decoded and re-encoded somewhere else (transformer?).

[manute]

yeah I suspected that as welll.
My idea was to return that order map first and set the values accordingly to the process. And then see if we can check the order after is loaded. But if is in other place that , this implementation is not enough, or it should be moved.

[jpfourny]

Same here.